Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 16:25:07 +0200
From:   Simon Horman <horms@kernel.org>
To:     Lin Ma <linma@zju.edu.cn>
Cc:     johannes@sipsolutions.net, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        avraham.stern@intel.com, luciano.coelho@intel.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] nl80211/cfg80211: add forgetten nla_policy for
 BSS color attribute
Message-ID: <ZNTzQ3QgKdWWpVop@vergenet.net>
References: <20230809033151.768910-1-linma@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230809033151.768910-1-linma@zju.edu.cn>
Precedence: bulk

On Wed, Aug 09, 2023 at 11:31:51AM +0800, Lin Ma wrote:
> The previous commit dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to
> NDP ranging parameters") adds a parameter for NDP ranging by introducing
> a new attribute type named NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR.
> 
> However, the author forgot to also describe the nla_policy at
> nl80211_pmsr_ftm_req_attr_policy (net/wireless/nl80211.c). Just
> complement it to avoid malformed attribute that causes out-of-attribute
> access.
> 
> Fixes: dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>

Reviewed-by: Simon Horman <horms@kernel.org>