Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230719194039.16179-1-Chaitanya.Tata@nordicsemi.no>
 <2307e1741e9d32e8f1ffc4e83c73b63a4e32512b.camel@sipsolutions.net> <CABPxzYJvAtgbrr_v6cMuKwFjzRjYOCDota+koYp-iogtJS75HQ@mail.gmail.com>
In-Reply-To: <CABPxzYJvAtgbrr_v6cMuKwFjzRjYOCDota+koYp-iogtJS75HQ@mail.gmail.com>
From:   Krishna Chaitanya <chaitanya.mgit@gmail.com>
Date:   Fri, 11 Aug 2023 00:17:49 +0530
Message-ID: <CABPxzY+_2DEK-wfAr1V9z1iHZky-7vF24mQx2yFgtFUoTdWgmw@mail.gmail.com>
Subject: Re: [PATCH] wifi: Add support for sending BSSMaxIdle in association request
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 11, 2023 at 12:05=E2=80=AFAM Krishna Chaitanya
<chaitanya.mgit@gmail.com> wrote:
>
> On Tue, Aug 8, 2023 at 4:43=E2=80=AFPM Johannes Berg <johannes@sipsolutio=
ns.net> wrote:
> >
> > On Thu, 2023-07-20 at 01:10 +0530, Chaitanya Tata wrote:
> > > When WNM is enabled, a station can send its preferred BSS maximum idl=
e
> > > period in the association request, add a new netlink attribute to get
> > > this value from the supplicant and add BSS maximum idle IE in the
> > > association request.
> > >
> >
> > I don't see anything here that even requires all this code, rather than
> > wpa_s just including the element itself in the association request extr=
a
> > IEs?
> Yeah, WPA supplicant can prepare this, please ignore, thanks.
Just remembered why I had to implement this in kernel, the associate/connec=
t
data structure in wpa_s `wpa_driver_associate_params` doesn't have any
ies/extra_ies, it only gives wpa_ie and rest all are parameters for mac8021=
1
to use. So, had just extended this as well, do you think we should add
this ies/extra_ies
to the association like we do for scan? Or as MLME is in mac80211,
just use this patch as is?