Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp701329rdg; Thu, 10 Aug 2023 17:27:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXIkYrxTaP1XnyPeQ3ThMe9L/iMAbk7hpQMw3VGymzavnXxM15XzPMTnXfGsHrGSjmvIlA X-Received: by 2002:a17:906:73c8:b0:977:befe:d888 with SMTP id n8-20020a17090673c800b00977befed888mr302701ejl.13.1691713666347; Thu, 10 Aug 2023 17:27:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691713666; cv=none; d=google.com; s=arc-20160816; b=F6zMvkpIjZ0Xc2In0CE2xu5+BCuur0q3i3O1gVXM35G5E8yl5Gs/svD7AZ2DWWH9Jv nLbAnPC2L+X2hjlfMoyrXg6+4J+cxBKHoxEqCEHumZPsMIuEatHd5aLE7FnvsPF4i5nR mzkhk+/Xrbirsi7el5DBqGWKMT3wV4PlqJdankZs3xpCuXEq03XVFFXyLjF8GvfeQoeU SCPpr4aUayIMt9jFkkij4BuI7Ds1fFDDHW9/xNzsuhIpKrWi6pdVQsPRKzFBC33jX8Jt UQXqIh3ur6/ytMys3FSHi5OFy/90Jx4ZfjNaAtgaG9lb6qLR+kFjg3awb3zRJtWN+U20 QZGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zFP7qz6oliD2INbwobgTLc91s+rnyjq9ywPTuKDl+Ng=; fh=wTOsYOFxyFUO1svkhz0dhcQB9IdmTPKTMfQoqapMmDI=; b=LcGnSKB9Zan7BHLZlUG6edveOs9cD9sB4i4eMzD34eFvLkv/Tz4YqlKApSrWPWsvL6 UQFBFibpKyPqRb9VUYMes5FqZUXKqVUvR26HKfUjeYHejcIEHjnfuTJ01AXxn4uOWQSc wBUkVZwxUZcU2jVDhvayITkYdydzBPuIXhTCISVg/xLZZBT1M7/BNtEFVAd9MD6mtaTQ 3QzNerrpV9OKe2qwEUnhAZIsMtdCdRQRCO/GUnW6FSeG3rxRm6QFWUe/DIxXc/q2gTLZ ydeNrqoh8QGPUj0yIUBvM7NemX8avwAk1ozCAUhhe4wdspntEwQTN2mEPbMTiVfjBim0 x9/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="n/0oc6QF"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a170906868b00b00992b63c9f9csi2512075ejx.456.2023.08.10.17.27.26; Thu, 10 Aug 2023 17:27:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="n/0oc6QF"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjHJXwo (ORCPT + 55 others); Thu, 10 Aug 2023 19:52:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjHJXwn (ORCPT ); Thu, 10 Aug 2023 19:52:43 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C752D44 for ; Thu, 10 Aug 2023 16:52:43 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1bc83a96067so11159415ad.0 for ; Thu, 10 Aug 2023 16:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1691711563; x=1692316363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zFP7qz6oliD2INbwobgTLc91s+rnyjq9ywPTuKDl+Ng=; b=n/0oc6QFrfzlTLcmcFhoji19B7LnhyawU9348NY1Gpm0N3D8xruG5VJP0+XmlIaQd6 BrfDuzjnvWmmj09UMZcNBhJ4ULsVBZoiSr+G+uXRJx2T2gX5l8Or6bbPhLrHduYYS4Rw wnF4oRarIaLS8d20YkENZliiFSDfZWT91kL+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691711563; x=1692316363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zFP7qz6oliD2INbwobgTLc91s+rnyjq9ywPTuKDl+Ng=; b=S+K2RdPFjP06oU27BXMBW4yazK/vfsRvgZcZO94gPtb86V47s4rbFs3/cp8A2zZEQF ZRlf5ANPwHl8O46/OfUK8VB91EsRfkSuTWp7t9ICZKI+NRRc5vImCMr4CN8j2MsNQMAw 0z7NTi+5fkjS+8hU8crCnSkZHqaOQgW3nZ4W7Oj1ck+HPpbnErmHx3wk9UEBpFjAw4NX klaNBhpRruRg0smTLAuKT41DgAIU5rkbVs1j3HjWJ4+OtjeDuz0x7vV7kwvrV8tlTtWb cq03k1gSNdyV+62oemnOs2/J0zUWjyiiOETbea3aaNL4PUV2D/Ic6vYq03w1cnE9gOvj oHeg== X-Gm-Message-State: AOJu0YxhytKoZIElRMo3FxHvXWp2EXNYlgz2bQqJr24ujA+KewGsZ+Yz xN2IlMiEU+vOI5ElJCVJL+DX8A== X-Received: by 2002:a17:902:ec06:b0:1b8:5b13:5958 with SMTP id l6-20020a170902ec0600b001b85b135958mr255467pld.31.1691711563040; Thu, 10 Aug 2023 16:52:43 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:4ec8:57d8:e207:3679]) by smtp.gmail.com with ESMTPSA id u12-20020a170902e5cc00b001b80de83b10sm2361557plf.301.2023.08.10.16.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 16:52:42 -0700 (PDT) Date: Thu, 10 Aug 2023 16:52:40 -0700 From: Brian Norris To: Polaris Pi Cc: johannes@sipsolutions.net, kuba@kernel.org, kvalo@kernel.org, matthewmwang@chromium.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: Fix missed return in oob checks failed path Message-ID: References: <4933455600e633c8cbafc0fc3180a7023894f8c9.camel@sipsolutions.net> <20230810083911.3725248-1-pinkperfect2021@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810083911.3725248-1-pinkperfect2021@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Aug 10, 2023 at 08:39:11AM +0000, Polaris Pi wrote: > Add missed return in mwifiex_uap_queue_bridged_pkt and > mwifiex_process_rx_packet. > > Fixes: 119585281617 ("wifi: mwifiex: Fix OOB and integer underflow when rx packets") > Signed-off-by: Polaris Pi Reported-by: Dmitry Antipov And: Acked-by: Brian Norris