Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fbdfaef1-d680-c58b-f048-306ec8623ced@quicinc.com>
Date:   Fri, 11 Aug 2023 14:46:35 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0
Subject: Re: [PATCH 2/2] wifi: ath12k: fix undefined behavior with __fls in dp
To:     Johannes Berg <johannes@sipsolutions.net>,
        <ath12k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>
References: <20230809042738.13394-1-quic_hprem@quicinc.com>
 <20230809042738.13394-3-quic_hprem@quicinc.com>
 <5cabcc57acd781e90c35fcc9b3c6a8aa8fbaa581.camel@sipsolutions.net>
Content-Language: en-US
From:   Harshitha Prem <quic_hprem@quicinc.com>
In-Reply-To: <5cabcc57acd781e90c35fcc9b3c6a8aa8fbaa581.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/9/2023 5:47 PM, Johannes Berg wrote:
> On Wed, 2023-08-09 at 09:57 +0530, Harshitha Prem wrote:
>>
>> During the crash, the fragment id of that packet was 0 and
>> __fls returned a junk value. Hence, it was identified that "__fls"
>> would have an undefined behavior if the argument is passed as "0".
>> Therefore, add changes to handle the same.
> 
> Umm. That makes it sound like you are surprised by this behaviour of
> __fls() and expected something else?! Please go read the documentation,
> and then rewrite the commit message. You really shouldn't be surprised
> by this.
> 
> johannes

Thanks Johannes for reviewing the changes. Sure, I will update the 
commit message in next patch version.

Thanks,
Harshitha