Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Lin <yu-hao.lin@nxp.com>
To:     Francesco Dolcini <francesco@dolcini.it>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: RE: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to support host
 mlme.
Thread-Topic: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to support host
 mlme.
Thread-Index: AdnLM9yJ3sHx+trUShG5sDbPtsfBhgAN8B0AAAMu0UAAB4TpAAAYtp9AAAwrgIAAivjV8A==
Date:   Mon, 14 Aug 2023 02:21:51 +0000
Message-ID: <PA4PR04MB9638F951BC7895315274BC79D117A@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <DU0PR04MB963607ADBFC49C7AB713092DD113A@DU0PR04MB9636.eurprd04.prod.outlook.com>
 <ZNSrYEJ9m0jO/WU9@francesco-nb.int.toradex.com>
 <PA4PR04MB9638C1DB606524BD57AB59CED113A@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZNTzMrjfauSJN1ym@francesco-nb.int.toradex.com>
 <PA4PR04MB9638C81BE986779C9512E262D110A@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZNXqt62xMQFQh16o@francesco-nb.int.toradex.com>
In-Reply-To: <ZNXqt62xMQFQh16o@francesco-nb.int.toradex.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AAJYzYbwblyuP7PUhiqzQ/gcJ5UiYO4h42EB+KqQZcIpjMKSXr76oOAjNNTL?=
 =?us-ascii?Q?lEU85kP98KgJOcs6EoNrWHkF9DSUcXfTgBc1UaMYeW0ttj9Qv8FUI7mSyluj?=
 =?us-ascii?Q?p1UMjTQ2QoVLaKaducKJWfILX9YeLWcfYypD64XRAaKyiSyZxSeVgXe3R3vN?=
 =?us-ascii?Q?JttLy2LQ+jhv6XeMmXoo0qwG4kAvlGk+5pu+ZSQu+7/wzKUxxPeZRVm19qrD?=
 =?us-ascii?Q?y41XLVsME/EbhYybmK4AgaDmiWnHEzaW1a4TZFHh3OMPxL/zCgzTWhu2s/VR?=
 =?us-ascii?Q?J2K7Qznu4HJVuPgYHFvO+HiKGolgZykIUnO8k6243jzsXEIDWPJNemXTrk8B?=
 =?us-ascii?Q?LT0Ity94j7tJ9PAE71KitOVLKVv0QaEWb2Qb1V5zar07YhMJWwkP2mQU+Hrf?=
 =?us-ascii?Q?D3BI0bldDxsAfRvjGAsGIXWyVghNcAAW9F/9svbnfKji3YOG8mNKizgf91cY?=
 =?us-ascii?Q?MjOZJQSf7de2u578LUICVMTflwLJeQK7kbF95TLgdnz1Z2681iRUSgQ/c1l6?=
 =?us-ascii?Q?YjAqiASKl3LkAxJDKZB5nshY/1AlUN/qMmXGVTjpEwdLMBdKYjA5UstQbPPy?=
 =?us-ascii?Q?y+dUbXbc+R6ieqbXFabRfMjBbXjbbfGSOGWNu2VCyrE0R8n1IHlZbJFoBH14?=
 =?us-ascii?Q?OCVqmHXojhIESy8aEmKz92JuENz+JdcxVAsh4G/hkx4Q/dzrYlDtEacfmN9m?=
 =?us-ascii?Q?l6oNkGGLXLjhSen9l0I7Prx2eGGgD34JhSrfBm14bkjcNeWSiomM25gvm7Zf?=
 =?us-ascii?Q?y3k49QumZY/er2lzHtBeYmU7WsJ3uK/Yp5wh8HIXY32oIICH0Vw8MU3X+HiC?=
 =?us-ascii?Q?y9Ko4DhDdnBDTST1+5uCnJseQ3+QKM/dS/uhAgrBXvoSlyBXoAdbR0iyJ9to?=
 =?us-ascii?Q?dROruVqxBxXwtpqLjymJzvNMUJgriqyCJ3pcRr/8iCiUN6qIDgG2xyZCikUJ?=
 =?us-ascii?Q?p1WgIlTSbbwpMvwC49OuuBIAwUoDZo73WMBPjIb+sSjXWHK/7pxDD1qMXi9H?=
 =?us-ascii?Q?MydPYvfxDDPJlVp6JW8STHD2XIvoMPa+mvxwgaacjv0wQCcVsVID9C84DAGB?=
 =?us-ascii?Q?vzHYphDvgtUHn8TzqfJtbH8dwLZQ9NHKvEsTSyGW5Ab5wLgeirFsrXsZ6iSQ?=
 =?us-ascii?Q?oYUj832qGDx26oIKcJsJlhhTHsVfQMTpUq59357n+cH/Tl6nVJFbazK3C6C+?=
 =?us-ascii?Q?zXE4/YIv5KUMHTPJIEIpaXKEM2BU2tnEpLRxr86UbzTeOWYc3hVol24LpJTS?=
 =?us-ascii?Q?+XfVNB/auewymTcBUIKuS8hvr+06Au3ipvj13OAHWiX/5bwSQr9rkEOWYZz9?=
 =?us-ascii?Q?uGvLaLjB5/cB3dLbzTU9l/pFc+YXzz1UuU6bZw85KLesgVxn7yicxPqyk61N?=
 =?us-ascii?Q?qJYC8AOCbe/OiTeFheBpeb8VzwCdyMVUzziyHPDCrf/dZs17WbhuGcQoSD91?=
 =?us-ascii?Q?lT7RytUmuGOF9z7UyfNKA+D7Jh+ygtbKVCeEXP5K/I5CkC68tL7p7yE1v3g5?=
 =?us-ascii?Q?/EiR+H0AptKwzdgqwP/8Ig/o5MbrLyRtnk3h4KTO/7KSSTdLzq+7bh4jB2Mq?=
 =?us-ascii?Q?CNnfLDe5ecEpgx95jPBfn+xymKBncB025/vY+24w?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 224822b4-187e-419c-aa8f-08db9c6d3848
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2023 02:21:51.2464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ctvQD4Xg09tN+mBfiwjxfl7dFoj+ZnwXmOxfN89xSkqaPBBcxsvSNHo94iIP235K3BvDHYGZ6IIU0mF/T9U+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7367
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Friday, August 11, 2023 4:01 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; linux-wireless@vger.kernel.=
org;
> Sharvari Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to support ho=
st
> mlme.
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Fri, Aug 11, 2023 at 02:13:43AM +0000, David Lin wrote:
> > > From: Francesco Dolcini <francesco@dolcini.it>
> > > Sent: Thursday, August 10, 2023 10:25 PM
> > > To: David Lin <yu-hao.lin@nxp.com>
> > > Cc: Francesco Dolcini <francesco@dolcini.it>;
> > > linux-wireless@vger.kernel.org; Sharvari Harisangam
> > > <sharvari.harisangam@nxp.com>; Pete Hsieh
> > > <tsung-hsien.hsieh@nxp.com>
> > > Subject: Re: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to
> > > support host mlme.
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Thu, Aug 10, 2023 at 10:51:36AM +0000, David Lin wrote:
> > > > > From: Francesco Dolcini <francesco@dolcini.it> On Thu, Aug 10,
> > > > > 2023 at 02:39:21AM +0000, David Lin wrote:
> > > > > > 3. Firmware version 2 is needed for this feature.
> > > > > That would mean that we could just enable it for other Wi-Fi
> > > > > chip variant that has firmware version 2, after testing it?
> > > > Yes. But I only tested with IW416.
> > >
> > > Can/should we probe the firmware version at runtime, instead of
> > > hard-coding this?
> >
> > Firmware version is reported by firmware after firmware is downloaded.
> What's the problem with that? You cannot really do anything till the
> firmware is loaded?
>=20
> If I understand correctly the possibility to use this feature requires it=
s
> counterpart to be available on the device firmware, this should be the
> criteria to use to decide if this functionality should be enabled or not.
> Hard-coding this depending on the actual device does not look correct to
> me.
>=20

If firmware is old and supports firmware v1, you should not enable host mlm=
e for the firmware. Firmware version is detected at runtime when firmware i=
s loaded.

> Francesco