Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230813212343.245521-1-artem.chernyshev@red-soft.ru>
In-Reply-To: <20230813212343.245521-1-artem.chernyshev@red-soft.ru>
From:   Jonas Gorski <jonas.gorski@gmail.com>
Date:   Mon, 14 Aug 2023 09:19:14 +0200
Message-ID: <CAOiHx==NiPG2GdZNrJn5hPEdi70Spe9Kc9CHO5NjnATAjCgUsg@mail.gmail.com>
Subject: Re: [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code
To:     Artem Chernyshev <artem.chernyshev@red-soft.ru>
Cc:     Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Arend van Spriel <aspriel@gmail.com>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 13 Aug 2023 at 23:31, Artem Chernyshev
<artem.chernyshev@red-soft.ru> wrote:
>
> Since wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy()
> can not return false it's impossible to get true value in this
> if statement

If they can only return true, then maybe their return types should be
changed to void as well? No point in returning a value when the only
caller is ignoring it.

>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>

Regards,
Jonas