Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 12:27:28 +0200
From:   Francesco Dolcini <francesco@dolcini.it>
To:     David Lin <yu-hao.lin@nxp.com>
Cc:     Francesco Dolcini <francesco@dolcini.it>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: Re: [PATCH v3] wifi: mwifiex: added code to support host mlme.
Message-ID: <ZNoBkF12PCZARO76@livingston.pivistrello.it>
References: <DU0PR04MB963607ADBFC49C7AB713092DD113A@DU0PR04MB9636.eurprd04.prod.outlook.com>
 <ZNSrYEJ9m0jO/WU9@francesco-nb.int.toradex.com>
 <PA4PR04MB9638C1DB606524BD57AB59CED113A@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZNTzMrjfauSJN1ym@francesco-nb.int.toradex.com>
 <PA4PR04MB9638C81BE986779C9512E262D110A@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZNXqt62xMQFQh16o@francesco-nb.int.toradex.com>
 <PA4PR04MB9638F951BC7895315274BC79D117A@PA4PR04MB9638.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PA4PR04MB9638F951BC7895315274BC79D117A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Precedence: bulk

On Mon, Aug 14, 2023 at 02:21:51AM +0000, David Lin wrote:
> > From: Francesco Dolcini <francesco@dolcini.it>
> > Sent: Friday, August 11, 2023 4:01 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; linux-wireless@vger.kernel.org;
> > Sharvari Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> > <tsung-hsien.hsieh@nxp.com>
> > Subject: Re: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to support host
> > mlme.
> > On Fri, Aug 11, 2023 at 02:13:43AM +0000, David Lin wrote:
> > > > From: Francesco Dolcini <francesco@dolcini.it>
> > > > Sent: Thursday, August 10, 2023 10:25 PM
> > > > To: David Lin <yu-hao.lin@nxp.com>
> > > > Cc: Francesco Dolcini <francesco@dolcini.it>;
> > > > linux-wireless@vger.kernel.org; Sharvari Harisangam
> > > > <sharvari.harisangam@nxp.com>; Pete Hsieh
> > > > <tsung-hsien.hsieh@nxp.com>
> > > > Subject: Re: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to
> > > > support host mlme.
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > On Thu, Aug 10, 2023 at 10:51:36AM +0000, David Lin wrote:
> > > > > > From: Francesco Dolcini <francesco@dolcini.it> On Thu, Aug 10,
> > > > > > 2023 at 02:39:21AM +0000, David Lin wrote:
> > > > > > > 3. Firmware version 2 is needed for this feature.
> > > > > > That would mean that we could just enable it for other Wi-Fi
> > > > > > chip variant that has firmware version 2, after testing it?
> > > > > Yes. But I only tested with IW416.
> > > >
> > > > Can/should we probe the firmware version at runtime, instead of
> > > > hard-coding this?
> > >
> > > Firmware version is reported by firmware after firmware is downloaded.
> > What's the problem with that? You cannot really do anything till the
> > firmware is loaded?
> > 
> > If I understand correctly the possibility to use this feature requires its
> > counterpart to be available on the device firmware, this should be the
> > criteria to use to decide if this functionality should be enabled or not.
> > Hard-coding this depending on the actual device does not look correct to
> > me.
> > 
> 
> If firmware is old and supports firmware v1, you should not enable host mlme
> for the firmware. Firmware version is detected at runtime when firmware is
> loaded.

What I am trying to say is that in mwifiex we should just decide to enable or
not host mlme at runtime after we know if the firmware support this
functionality.

Francesco