Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f54ac1e5-4a3d-780a-0e83-5a26b472c17f@quicinc.com>
Date:   Mon, 14 Aug 2023 07:40:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/2] wifi: ath: Use is_multicast_ether_addr() to
 check multicast Ether address
Content-Language: en-US
To:     Ruan Jinjie <ruanjinjie@huawei.com>, <kvalo@kernel.org>,
        <briannorris@chromium.org>, <johannes.berg@intel.com>,
        <Jason@zx2c4.com>, <toke@toke.dk>, <tj@kernel.org>,
        <mukesh.sisodiya@intel.com>, <quic_vjakkam@quicinc.com>,
        <johannes.wiesboeck@aisec.fraunhofer.de>,
        <linux-wireless@vger.kernel.org>
References: <20230814124212.302738-1-ruanjinjie@huawei.com>
 <20230814124212.302738-2-ruanjinjie@huawei.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230814124212.302738-2-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/14/2023 5:42 AM, Ruan Jinjie wrote:
> Use is_multicast_ether_addr() to perform the Checking.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>

> ---
>   drivers/net/wireless/ath/key.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
> index b7b61d4f02ba..21a93fec284d 100644
> --- a/drivers/net/wireless/ath/key.c
> +++ b/drivers/net/wireless/ath/key.c
> @@ -104,7 +104,7 @@ bool ath_hw_keysetmac(struct ath_common *common, u16 entry, const u8 *mac)
>   		 * Not setting this bit allows the hardware to use the key
>   		 * for multicast frame decryption.
>   		 */
> -		if (mac[0] & 0x01)
> +		if (is_multicast_ether_addr(mac))
>   			unicast_flag = 0;
>   
>   		macLo = get_unaligned_le32(mac);