Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f218a49-e4dc-4a6f-8f80-338ed4dae207@amd.com>
Date:   Mon, 14 Aug 2023 11:41:57 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: firmware-iwlwifi: Wireless AC 7265 lacks D3cold support
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "Greenman, Gregory" <gregory.greenman@intel.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        "usa@junocomputers.com" <usa@junocomputers.com>,
        linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-pm@vger.kernel.org
References: <20230814163528.GA177266@bhelgaas>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20230814163528.GA177266@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDU3UTg1MFM2NjgwdzBTTE9ncnpOTG5mc051NkdCYnZIcElTbW9WcWpsU0o3?=
 =?utf-8?B?dEtQaHFTSG1rWDd0Umx6cVZROXhqMG1Na1FYb3ZhdnZYeG9lOTFoZ2w2aWY0?=
 =?utf-8?B?WnFzSjN3VlFhOGthbkpTQjBqRm9xRndPUEZKSTh2OUovakQxNVJRRGU3OXV2?=
 =?utf-8?B?ZnVucC9td3ZESGpvTGxCRlhzdGRsSVVPbjk3bkNrVk51V0FCbW9WZURyS1lJ?=
 =?utf-8?B?OW9neGNoVnhRRGRQbExYY0tSc3p0N0Y5enRIYUF6QlZnaEYvS3huWWxsdVlM?=
 =?utf-8?B?aitETlJtU0oreG5ZQUY4Uk1Ba0QxMDdsSXdLVFVzd1AyR1psRWsvS2xJV2RV?=
 =?utf-8?B?czZaVVM4emRuaVJJT2xkaXkrUkJPSWUxQTUybmlyRE5zZzAyR2pGalhUSk1C?=
 =?utf-8?B?UDVUbE13RVlTenQxbmRhbkVpZk5XbDd2NlBTU1dIbFdlSTlMejJsRnc2cFE3?=
 =?utf-8?B?bGVDUFIxaERCOUN2b0JYeFhuWVlMVmNITUIxVlZORzg1Yjh6REVDMkgvSndv?=
 =?utf-8?B?OTROTUtJM2p4M1hwVmkvcHFJdVBDTnRScnRpQlZHSnFuQkZMUUM5cE1QdWl0?=
 =?utf-8?B?cE1nRHg2bFRtcVphYitsQkxCbEhTRkVWYkxGRVhCUHJsOTJuQU5WMFRzMjB5?=
 =?utf-8?B?Rk1BaVhEVWFjYmUvN0xLTnV0cFRtQ1NWNGhPVzEzcVYrQW5kZkRGN3BHTDFL?=
 =?utf-8?B?YTUrV296ZVBpTDNaU0xRaGNEcDlCSDJJRGV4TFpYQk5FTjhLbVp6VXNFRW1F?=
 =?utf-8?B?ejl0OE1iSWtXYU8xa2xRMzdCd3drYmp3TEswMTA3L1VQVGoxVkdHYTlXdFpx?=
 =?utf-8?B?TlFxRk1YNVQ5aHVvTStQSG5NZXBXNUc1aUhka0hqVUl1S2hSOEhUQmc1TDhW?=
 =?utf-8?B?WkRzMTRiWTdwYTk5aUFydEpwbVAydktsMTBobUNTOGhPMTZLaEN5T0lmUzN6?=
 =?utf-8?B?dWxCNFBkRXVjSVRyZi9laGVVTHFaUTIwa3FDNVZEYU9QSnZCU1BRcWtTUWZL?=
 =?utf-8?B?UTVFNWZja1NOaHFscXlhSTk2OFBsaEp1VTVRcWY0Y2ZRWnFPQWtvUVlpQ2RU?=
 =?utf-8?B?UzZCaDZEOFo2MjloVm93cWtKUzhwN1Q1RVJpNG5tSGVZZXlGeGNmZGliY1RL?=
 =?utf-8?B?ZmRQMEJOOXpyYjByOExoZTVTcFd2VThyRzdrRkZzRVpMS2ZoNC85NitpYnJn?=
 =?utf-8?B?NGdyMitYRUxxK3FMcGF0OUdEVENXVFlheWtXdVdzWUFjV3I0eWZVeFl4MUNV?=
 =?utf-8?B?U29pM3JRZWdXSHB2ZHB0aTIxN1NqdXFkYk1kT1hoUWpOck82WlIycVBGQlRv?=
 =?utf-8?B?V25ZZXdsL212cUtBMFkyVHJPaUJVZTF2RjBNeTJkSkh5ckVJVERPdmVFd01B?=
 =?utf-8?B?V0NuUWtjbW1ZZkZtR1Bramd3bHFTQU1CU1doUmNaR1FJajBwYVNwaXA4Zlg2?=
 =?utf-8?B?Sy9XZ2Q2ZVBsc1Y0OWxQSjRwMytlaW5ieUpjUzFFSHR4eEhQbGQ1Q1BsWm55?=
 =?utf-8?B?ZWhvUFlZdS84SFBCOXRkaVV0b0NtRVhnTnJzcFMreGU3VmZJWHhLdi9LbGNv?=
 =?utf-8?B?WkVaT3dTMXNWS3QyL1FVeHg3VFlSTERYT3RmOUZuYjdpTnRnc01ZWVpLRCs2?=
 =?utf-8?B?Ri9jOE9iNnMzaDRMOEVBU0cyQWd2ZDdUZTdRRkZ2RSsvTHA1MjRXQVFJOXhD?=
 =?utf-8?B?d2g3bkJxL1JMTlN3bDZ4TkFRN2JRdC9jbi9kaGRRWXhqYkp4bUo2cXNFZHJp?=
 =?utf-8?B?MHVpS1hGVHRhZXJtSWVQaFFTM21oQ0hxWFErYkp4TngrRGZ2eW51R3JXclE1?=
 =?utf-8?B?Y21YbFJ4bVpqVEk1WXdvN05zQk5wcU5KR0I3SGpNVVduZTMrWWszNlBvY0Rn?=
 =?utf-8?B?Z084WnMvM3FtWi91UUw2NEozY09TMGl1dXV3cVFHd0FQem90Rk5oTS8vdGFB?=
 =?utf-8?B?RzZpTVQ1QUZnWmlndllmR0F6Nm80Y3piTUJoSGxGcUY4OHYwcnlQTlZ4RjMv?=
 =?utf-8?B?OThleDl3MWpDbFB2bGNOeGtSRlVET1BJTWZvTGNYdU12TDJZbUNibDRTNDRK?=
 =?utf-8?B?UjhJOUJXOVBUR0xuZXlTVWUzbStJb3J1WjNIbHU3R0kzcU8yaDBKaHQ1ZTBC?=
 =?utf-8?Q?TI0Mxh6BZyxoanlq4uQFk3hWL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1718d389-aff7-4857-2ae3-08db9ce5622c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 16:42:01.3531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cu0l0SIaQ6EtCSIU5tES8360BekT1F8eVUohvLbSepq8crChlEvtzFgwGFGI2+EzHt716h1A62g7JKBZp+6VWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8185
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 8/14/2023 11:35 AM, Bjorn Helgaas wrote:
> [+cc Mario, linux-pm]
> 
> On Sun, Aug 13, 2023 at 03:33:21PM +0000, Greenman, Gregory wrote:
>> On Fri, 2023-08-11 at 15:34 -0400, Juno Computers USA wrote:
>>> Any updates on this?
> 
> D3cold support has been a problem area, and there are some changes in
> progress [1] that could be related.

Yeah; no harm in at least trying this series.  I'd love another data 
point with it.

> 
> Could you possibly collect the complete dmesg logs (with a recent
> upstream kernel, e.g., v6.4, if possible)?  And the output of
> "sudo lspci -vv"?  And the contents of /sys/firmware/acpi/tables/?
> You can attach them to the Debian bug report if that's convenient for
> you.
> 

Yes this could be related but it will come down to
1) Whether the root ports are considered power manageable.
2) The system uses S0ix or not.

whether the series could help as it stands today.

Please CC me into any kernel bugzilla that you open against a mainline 
or stable kernel and can capture the lspci output, the dmesg and 
acpidump and I'll look at it.

> Bjorn
> 
> [1] https://lore.kernel.org/r/20230809185453.40916-1-mario.limonciello@amd.com

BTW - Bjorn, can I have comments on the last patch in this series?  I 
have fixes ready locally for everything in the earlier patches that Andy 
gave feedback but I was hoping for some feedback on the very last patch 
before I sent out a v12.

Thanks!

> 
>>> On Aug 3 2023, at 8:01 am, Juno Computers USA <usa@junocomputers.com> wrote:
>>>> Dear Maintainer,
>>>>
>>>> If D3Cold is enabled from BIOS the tablet boots without Wifi.
>>>> The only two ways to enable wifi support is either by disabling
>>>> D3Cold from BIOS (not ideal) or adding pcie_port_pm=off to grub
>>>>
>>>> [   12.681303] iwlwifi 0000:01:00.0: Detected Intel(R) Dual Band Wireless AC 7265, REV=0x210
>>>>
>>>> This is needed for our new Juno Tab 2
>>>>
>>>> https://junocomputers.com/us/product/juno-tab-2/
>>>>
>>>> I also filed this under Debian bug-tracker.
>>>>
>>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036633
>>>> Thanks,
>>>>
>>>> Giovanni Caligaris
>>>> Juno Computers USA
>>>> P: (215) 509-5472
>>>> W: https://junocomputers.com/us
>>
>> This device is very old and actually already EOL, so I'll not be
>> able to get any support for this internally. D3 works fine with this
>> NIC on standard, off the shelf laptops, so I'd guess that the probem
>> could be rooted in the tablets' PCIe hardware or maybe the BIOS
>> itself.