Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp1185376rdb; Wed, 16 Aug 2023 04:32:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE22H5I9tSM7JIdkEh5MLaEIQXWmEYLIPqqY2zXWwwWE6Kwlakle28zAfue4IC4mbenbvGt X-Received: by 2002:a17:906:4e:b0:99d:f3ae:9a3e with SMTP id 14-20020a170906004e00b0099df3ae9a3emr1030861ejg.38.1692185558606; Wed, 16 Aug 2023 04:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692185558; cv=none; d=google.com; s=arc-20160816; b=P2JPLzFGfngQMLVzzuw22ivbHkGy0hG68Euk9Ly5mvjS0Bngz6QkVwF53v+eZCbCe8 HCXTyo7CtYGtniqSohXH1AHbNMPMpxP5UBs0CfI4Mbz57CxeqTTiulBLiOXV+SjC+fjy hpAQM1P4tUyHFPL0XGzgMqvHLVaRZBGTSZ/XsI7fRXSTFBQT9sLdhsBAvQFRU78QYeHl 1XSkRWMG/bVf0N+Z3e0aCGtd10xL+7AE+dae/oFrxDWEo1VV28moyGbZktr9lbqVUmkI WO0YqBdcvFi4X0IFYEhMzPiNY5yNHJhGsrgaj2LQq/ji55TEtt+pfgebVD0/2jnj5vw9 vL6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=jaR7L8KJRY+w/O6niQ/YQ0UYEgFIo3BEAompmFgrBJc=; fh=E0NBztyZv3Ip6T8qWzipRo5gA00Lh3OvnRhRwdZRqk4=; b=i0iapQLIGJSBDDsrI80LGyrmqV5SLHQcwYl7vYEdLAJtZPqkO/PGW0tmaKtDt3jYL7 JfZLuDcFsisB/C/ihxIxQfLDzIuNhbXsjljJgrGCdtpldbi09e5ON2DPK4tJISgsKK9B Pcld/ipGBDZnOgFKZrukyWrqd6LZC/P8LAg506P5g+1h7qqJPzj5i4pL7p72pP6ar9JM cQBh6TItAf49addBVOEjR5Kr56+D2wDWJXMk995X6CUy3Qwx3Gb2rN9BNq/c74CCuNBq m7Xf01KAi0K4FvIByuKB6gpZwqHWLPu9mcV1DyGfjay9fPHtG6HR39ZkLHWYTTr5+x5v OLGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a1709060e0b00b00991d54db2a6si11031433eji.693.2023.08.16.04.32.19; Wed, 16 Aug 2023 04:32:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241384AbjHPDMh convert rfc822-to-8bit (ORCPT + 54 others); Tue, 15 Aug 2023 23:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241541AbjHPDMd (ORCPT ); Tue, 15 Aug 2023 23:12:33 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 07305E6B for ; Tue, 15 Aug 2023 20:12:31 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 37G3C3dH4011173, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 37G3C3dH4011173 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Aug 2023 11:12:03 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Wed, 16 Aug 2023 11:12:23 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 16 Aug 2023 11:12:22 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Wed, 16 Aug 2023 11:12:22 +0800 From: Ping-Ke Shih To: Dmitry Antipov CC: Kalle Valo , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH] wifi: rtw88: add missing call to cancel_work_sync() Thread-Topic: [PATCH] wifi: rtw88: add missing call to cancel_work_sync() Thread-Index: AQHZz4TiR3KqrXrqz0KJOt5g7uGRB6/sPtWw Date: Wed, 16 Aug 2023 03:12:22 +0000 Message-ID: <0c3dbbdca1a2465fbbb9c8ea187c52b7@realtek.com> References: <20230815142908.92257-1-dmantipov@yandex.ru> In-Reply-To: <20230815142908.92257-1-dmantipov@yandex.ru> Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: Dmitry Antipov > Sent: Tuesday, August 15, 2023 10:28 PM > To: Ping-Ke Shih > Cc: Kalle Valo ; linux-wireless@vger.kernel.org; Dmitry Antipov > Subject: [PATCH] wifi: rtw88: add missing call to cancel_work_sync() > > Add missing call to 'cancel_work_sync()' in 'rtw_core_stop()'. > > Fixes: 5c831644e1f4 ("rtw88: handle and recover when firmware crash") > Signed-off-by: Dmitry Antipov rtwdev->fw_recovery_work is used to restart hardware when firmware reports things get abnormal. The calling flow will be fw_ recovery_work() -> ... -> rtw_enter_ips() -> rtw_core_stop() -> cancel_work_sync(&rtwdev->fw_recovery_work) /* wait for self to finish */ It would be safe to add this cancel_work_sync(&rtwdev->fw_recovery_work) in rtw_core_deinit()? So, NACK. Ping-Ke