Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440
Mime-Version: 1.0
Message-Id: <b29731ef-0a72-402c-846a-b37d86712641@app.fastmail.com>
In-Reply-To: <9a6b2c18b599e5c2e7cea99fec84a4ecb5092da5.camel@sipsolutions.net>
References: <20230616090343.2454061-1-arnd@kernel.org>
 <9a6b2c18b599e5c2e7cea99fec84a4ecb5092da5.camel@sipsolutions.net>
Date:   Mon, 14 Aug 2023 23:02:19 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Johannes Berg" <johannes@sipsolutions.net>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Gregory Greenman" <gregory.greenman@intel.com>,
        "Kalle Valo" <kvalo@kernel.org>,
        "Luca Coelho" <luciano.coelho@intel.com>,
        "Shahar S Matityahu" <shahar.s.matityahu@intel.com>
Cc:     "Mukesh Sisodiya" <mukesh.sisodiya@intel.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: dbg_ini: fix structure packing
Content-Type: text/plain
Precedence: bulk

On Mon, Aug 14, 2023, at 20:28, Johannes Berg wrote:
> On Fri, 2023-06-16 at 11:03 +0200, Arnd Bergmann wrote:
>> 
>> As the original intention was apparently to make the entire structure
>> unaligned, mark the innermost members the same way so the union
>> becomes packed as well.
>
> Hm. Not sure exactly what you mean by that, but shouldn't we make that
> "union { ... } __packed"?

Up to you, the effect is the same, as the other two members are already
packed. I generally try to keep the packing to the members that are
actually unaligned, to make the code more efficient, but in this case
the entire structure is unaligned, so it doesn't matter.

      Arnd