Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ping-Ke Shih <pkshih@realtek.com>,
        Ilgaz =?utf-8?Q?=C3=96cal?= <ilgaz@ilgaz.gen.tr>,
        kernel@pengutronix.de
Subject: Re: [PATCH] wifi: rtw88: usb: kill and free rx urbs on probe failure
References: <20230823075021.588596-1-s.hauer@pengutronix.de>
Date:   Wed, 23 Aug 2023 13:14:10 +0300
In-Reply-To: <20230823075021.588596-1-s.hauer@pengutronix.de> (Sascha Hauer's
        message of "Wed, 23 Aug 2023 09:50:21 +0200")
Message-ID: <87ttsqgj65.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Sascha Hauer <s.hauer@pengutronix.de> writes:

> After rtw_usb_alloc_rx_bufs() has been called rx urbs have been
> allocated and must be freed in the error path. After rtw_usb_init_rx()
> has been called they are submitted, so they also must be killed.
>
> Add these forgotten steps to the probe error path.
>
> Besides the lost memory this also fixes a problem when the driver
> fails to download the firmware in rtw_chip_info_setup(). In this
> case it can happen that the completion of the rx urbs handler runs
> at a time when we already freed our data structures resulting in
> a kernel crash.
>
> fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")

This should be:

Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support")

I can fix that, no need to resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches