Received: by 2002:a05:7412:1492:b0:e2:908c:2ebd with SMTP id s18csp494036rdh; Wed, 23 Aug 2023 06:29:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgzAAbTXdtXlIKjOsoxiIIPVA2oOtxOg4e/4MGO+0jztH5FY9bZb6Lf4lJeF32/JJ5Wr2j X-Received: by 2002:a17:906:7481:b0:99d:dce8:41d6 with SMTP id e1-20020a170906748100b0099ddce841d6mr9891645ejl.71.1692797397021; Wed, 23 Aug 2023 06:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692797397; cv=none; d=google.com; s=arc-20160816; b=X9QQTvod0D9YpwvAbenfpHBkT6oS0mTOy8vm38saCCZbKUc8M+92Z3hfj0TqQrtCmd ZWJASxBqQo7CisBdfhFDGub/69XsMMuHwaTn0n+gBssvrNcF9U7CVSNBw+ee3xjeJdSp qSOieuKcre/i6OBcMbjO73Z/LrCYPEbco2dFaKhvjpnX4PVtksTTfvAUv2dXo/PKBV2q /tY3LtfjYqIlSXFamxGsJtZDKF6ft9EyYlGkgnrc30wMOKcqStlLiBM5YJYWgQVOtg39 6j8hQLtMHmliLZ/HWUOB1q4BKLZyLwRykrDU14xmcZnOoYCWRzXUqhWqsIYjGkYfw2tD jNBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Z9alxbI1qNE0GhyWmP0RkmEjhw9zUJvqo4+9sGatFnA=; fh=Do33VbUvHByg5nehMNx232yugvLlYaJ9PeHVpjpGFpE=; b=cxoQ1q1r3lznGV7aorf7ju2V5I6ZVyDAnAPhxYyj9O9UUij/6m8yeQ6GUEAoEqPhvk X++VUzYvMbXNeC4tXtMnYWS08fgHCNQUyI3MgLPQVhGXiiUaJYyo/l2yoUTSIFb8BywN 2V1lMp0Fg7xcFua4IaY8ROo8AZYOmAg8+0PHkEnVlzpVD1dJLskJwlhTrCYSog47iv0S dR2wI0JhnxiFTlmhu76jy6WVXGa26IsAFcaSsl08PiwiAMlVpii2qLijELqA90+r+sid DFHCinRHzWYqA6kTrBygdbeymCAoBY4t0e6IVwk6j4PTl/yi5xeGqoUm5Wkj0kg7TuDP DH3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dVOypVtz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020a1709065ad000b0099bcc37923esi8756533ejs.690.2023.08.23.06.29.42; Wed, 23 Aug 2023 06:29:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dVOypVtz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233383AbjHWLL4 (ORCPT + 55 others); Wed, 23 Aug 2023 07:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232276AbjHWLLz (ORCPT ); Wed, 23 Aug 2023 07:11:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9A3CEF for ; Wed, 23 Aug 2023 04:11:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A5E262707 for ; Wed, 23 Aug 2023 11:11:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DF7EC433C8; Wed, 23 Aug 2023 11:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692789112; bh=8vHk0tpRBR5bgIX0w5RaScu5RRfiXsdFyM2JjEzp3Nw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=dVOypVtzaqNpEQcZpvvBpqhuElqYok07B6vaBJhgB3DtVKujUJ4EnM4v5aF2R/pkO wmVepaAWX7VHEHFt9AWaVpAoFpmpTFxVh2ovRalKekNjz6992pD8OGSp2lhEMcqYpr q72UOxm7c1BYh/icFcUTdkbkO9yt7bINeUIYAwCCNBP571UIBp+E2lmED3aQ1+wsaK FFoaPJauMRtTsD3fh/06UZWlRbLyZUzZRAlXzlZTQHaPmCvNhytLQ3uqWGFFBqHddM RpiBsms/q9DY0VCDeB/FwKj7TQ/xarnTULvyaMCDnKluKbS0qEyax/0UbQX2H7gL6c OwAfhPEK4icCg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] wifi: mwifiex: avoid possible NULL skb pointer dereference From: Kalle Valo In-Reply-To: <20230814095041.16416-1-dmantipov@yandex.ru> References: <20230814095041.16416-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Brian Norris , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169278910933.1133515.16503452502996769734.kvalo@kernel.org> Date: Wed, 23 Aug 2023 11:11:51 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov wrote: > In 'mwifiex_handle_uap_rx_forward()', always check the value > returned by 'skb_copy()' to avoid potential NULL pointer > dereference in 'mwifiex_uap_queue_bridged_pkt()', and drop > original skb in case of copying failure. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 838e4f449297 ("mwifiex: improve uAP RX handling") > Acked-by: Brian Norris > Signed-off-by: Dmitry Antipov Patch applied to wireless-next.git, thanks. 35a7a1ce7c7d wifi: mwifiex: avoid possible NULL skb pointer dereference -- https://patchwork.kernel.org/project/linux-wireless/patch/20230814095041.16416-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches