Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] ath5k: fix WARNING opportunity for swap.
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230815040819.649455-1-mahmoudmatook.mm@gmail.com>
References: <20230815040819.649455-1-mahmoudmatook.mm@gmail.com>
To:     Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Cc:     jirislaby@kernel.org, mickflemm@gmail.com, mcgrof@kernel.org,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169280018252.1336947.9195494625523438821.kvalo@kernel.org>
Date:   Wed, 23 Aug 2023 14:16:24 +0000 (UTC)
Precedence: bulk

Mahmoud Maatuq <mahmoudmatook.mm@gmail.com> wrote:

> coccinielle reported the following:
> ./drivers/net/wireless/ath/ath5k/phy.c:1573:25-26: WARNING opportunity for swap()
> 
> while trying to fix the above warning, it reveals that ath5k_hw_get_median_noise_floor()
> had open-coded sort() functionality. Since ath5k_hw_get_median_noise_floor() only
> executes once every 10 seconds, any extra overhead due to sort() calling
> its "compare" and "swap" functions can be ignored, so replace the
> existing logic with a call to sort().
> 
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
> Suggested-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

e10ec6ea612c wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230815040819.649455-1-mahmoudmatook.mm@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches