Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp815336rdb; Fri, 25 Aug 2023 01:43:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH40zvbDiAo+LtPrQWC2xvmTQSm8KnMYaSALkurfi763SaEIslsqamOJidR/upK1vxKCqOd X-Received: by 2002:a17:90b:e8b:b0:268:8ff2:5c0d with SMTP id fv11-20020a17090b0e8b00b002688ff25c0dmr26471768pjb.17.1692953028665; Fri, 25 Aug 2023 01:43:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692953028; cv=none; d=google.com; s=arc-20160816; b=B/zzhMbnTGjCxSR+Vh0HQX0qTKItCnS5YvyQ8q1e78cebgvCVaYRBJZmB0aRFcPo37 GmFDl3lntb+9y10EthKt5s3M99YgaAE4Ua2Ury5MKNFRM3iRMoih+N6hBfCgPO16AyMP OV/tDoKdGp0oOREkZHdKr8gKIzFoC89y+fx3UvICrNlmibcTzTw+M2MIP10tlAGMSY6O tcriFXYgu7vMKB6ziu9A4olLG/HPo3bpIpBTOTa1vB9ScJHu2yszXF4+dqx8/a/+Feyt 9x1cEJh9vZGDdEyGhTnxSDfvfRK5FRNpS9eZNEy/orWeSExedRy0ALEuJF2jMRJRj2Dw kH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=wt+qIMGUhayQeMx4S1WrQTpcWHYpXsB2RQX/Qj5w0rU=; fh=Y+3EpZo8Un26gMMJxMkfe0aOyfeeZLrygXyn4Fmcaq8=; b=EA0o9V7T7RMuBbR/QdjEvGEwEvfCnv2xr1zUn38aT4f1PGJxwMeWZL3CIalUpDeKL7 9224JQ17ZJKf4GIGrwSIQ6DKhB28+c1TLXcCqcBPjOc0kt0rZkhGFjvwmT8c9jdDKIzN w/xx6gJZxZ07geG1E6UHFEegbb415Ov7ws8ft7Rbbdcxuy9rbMfElo+DjWxNg3YbSMb5 D029uOH/A6eZTvHR2yQGjExRINIcT44s0O2/ypeFhbjSaiNJVHT7w1yqWomyWlC2VWaR LPHaou0j2dfddenhZzrDo49ZyuBuihf3w2rV4m7gvXVwNppM+dtzFS0kthsHFwnae3wx QZrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UHWYhGuV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a17090ab90500b0026958e977a4si3911888pjr.19.2023.08.25.01.43.40; Fri, 25 Aug 2023 01:43:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UHWYhGuV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241794AbjHYHgB (ORCPT + 51 others); Fri, 25 Aug 2023 03:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243245AbjHYHfx (ORCPT ); Fri, 25 Aug 2023 03:35:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6052109; Fri, 25 Aug 2023 00:35:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA75A614B3; Fri, 25 Aug 2023 07:35:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 545EAC433C7; Fri, 25 Aug 2023 07:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692948940; bh=XPNtAfyvKj/g+y5Rpwes+9pS9wajftJiM2gsLqx24fc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=UHWYhGuVuMmm4aqV+hto3J1sYBnTWnIolq8A5PUKDau/MfCY53auUc8nnT0aiG27z SN2vXKbFq56z6V4zJMYRM0nPF5M8H6NSqyKQ5bMwiApCpW82t6CM8b5mvOaMHMNjxG o3AEHtDvgnXypMQmp7Y4PBt5NDmLW6HWPp8vVb//QBlLez+BZwu9AITBDl0FYWIBHt fcl4Eaaa+V5sNEA40/15msmV4qXhRF1j2s3mC/51CBN95vkX9iQ8V+H/EivLGuj39P OOHDh+AbIuYOQJG9n7IYnla8KF4/B9Xxf15z9ne+277CBbBMbOJPk4NLziAlGoYw+Q wldoIfBQ0gxpA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v1] net:wireless:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() From: Kalle Valo In-Reply-To: <20230713030358.12379-1-machel@vivo.com> References: <20230713030358.12379-1-machel@vivo.com> To: Wang Ming Cc: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Rajkumar Manoharan , "John W. Linville" , Sujith Manoharan , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Wang Ming User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169294893610.1674223.1208799816873106062.kvalo@kernel.org> Date: Fri, 25 Aug 2023 07:35:38 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wang Ming wrote: > The debugfs_create_dir() function returns error pointers, > it never returns NULL. Most incorrect error checks were fixed, > but the one in ath9k_htc_init_debug() was forgotten. > > Fix the remaining error check. > > Fixes: e5facc75fa91 ("ath9k_htc: Cleanup HTC debugfs") > Signed-off-by: Wang Ming > Acked-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1e4134610d93 wifi: ath9k: use IS_ERR() with debugfs_create_dir() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230713030358.12379-1-machel@vivo.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches