Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp815508rdb; Fri, 25 Aug 2023 01:44:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEut2qlSuJv2GGt+LJzP4ML7I7OxgHQ+Zz5bG8WsRS3Z/PCFJcx8VhKyvWuGSmCXWZN9h6T X-Received: by 2002:a17:902:d488:b0:1bf:7dfd:5b05 with SMTP id c8-20020a170902d48800b001bf7dfd5b05mr21477782plg.27.1692953058890; Fri, 25 Aug 2023 01:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692953058; cv=none; d=google.com; s=arc-20160816; b=KXJdkqKrQKvCWa+6lu7RpexPrw/Alv6tMNMiAlpMoLB2fdGE3I1K7cxO9nyDw+dEdS QJa9OeukRhDinfTSgYzrNdDkmuJj11d1sVtG6Mch8gfmwm1JEQjxjvylRHByJOLiIJHn iSh5xwT4JSPOatKnABKzeoaKoWKGRpHzKoP9vL7+zYEXx6BUtHoSO13QEFQTVET548cx ZO+8gaXtd1o5UAXXs4aU7nPP5bZA9hh71nszDCDBifuKScYw82aOdr5mpWi9P+zEww2y a86zmzgzprntocdOYc235SpQ+LEfHFNrv8n+cNQFyxiIfwFSV9vrWNXfR5GpO3rGwT6T 0jAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=sJRXCwKEc9VKpz2sHTk0IJIBJ1mYE2eyPvZLNhEf21Y=; fh=pFUMRLcs2CxJLfynOFPNNsxKPxj2wYRvMQW6PkoiSbA=; b=UlZfpTVhkwZKS7fBLTnaYW3XNrLK9xWUlfEFQScv6T3tHcy+NMsrtOkvIiDhRtd5mw zmeiGF5BERfgtaXDoEBfeCdV3eJ61jgno+yCnUsXSoqzQCYOD8kXjJz4z9b9T0Im0e5y q3MCyinP9HpTcf7FhNcVXKKR1WMYj4GbrULSijB4zwEVEuqhgVQHjiKCt7kMta1furr/ AqYABBSS+1se02LEulkySPUMhgL4d3EM3pK6QQfrd32HiUkNzuTt7WXTre4grNp5OWSN L/sa6HUAQn4XXpJI+FuLzdJV4N2SLKRtTL5yNUiP/z9XwcAoixQTi0Lc2ZIatJGkTPfW F2gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nrg6nBDr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a170903210900b001b9e8ebe5a0si1232307ple.613.2023.08.25.01.44.10; Fri, 25 Aug 2023 01:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nrg6nBDr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbjHYHhk (ORCPT + 51 others); Fri, 25 Aug 2023 03:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243251AbjHYHhP (ORCPT ); Fri, 25 Aug 2023 03:37:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF9F2115 for ; Fri, 25 Aug 2023 00:37:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 477DE6194B for ; Fri, 25 Aug 2023 07:37:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2F92C433C7; Fri, 25 Aug 2023 07:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692949029; bh=hN0YbyiYrl8AjNUF/1t/u5T7kx0yqD0TeUUlrQE2plg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Nrg6nBDrMmxqXdYF5fepANNakZ7UkIAotoNtbwc/ZYvUo3ge0Z4xybUE97XE40+bh l/wsMOPQnsr3Yt2FpX6xz3aDvrAL0c3W/WNb/E/jyY0VFyDwlJUbD9gtsP9QNM6Bi+ 98huwsfWDrVMTg/Hkiot6TUdq3TpqfOost/R8noAqYVO8q6k/KBuzyBAqY3oM+C3Dt /xR25VLENxo5AvVBfDo3TrNIOLyzdvseW3b1fEDrF8/qKiDN/8pBPMsnAKDO3rL+UD W1TxSYV9jUYwcTXZW48LrAHu6fdv84dhhr93wqHo3KJApgSxHrJCIVsmf0PeBjIUD0 iSGzIdeAVh17A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: ath12k: add check max message length while scanning with extraie From: Kalle Valo In-Reply-To: <20230809081657.13858-1-quic_wgong@quicinc.com> References: <20230809081657.13858-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169294902664.1674223.5798401346278788819.kvalo@kernel.org> Date: Fri, 25 Aug 2023 07:37:08 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > Currently the extraie length is directly used to allocate skb buffer. When > the length of skb is greater than the max message length which firmware > supports, error will happen in firmware side. > > Hence add check for the skb length and drop extraie when overflow and > print a message. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong > Reviewed-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 2f5124e86ae7 wifi: ath12k: add check max message length while scanning with extraie -- https://patchwork.kernel.org/project/linux-wireless/patch/20230809081657.13858-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches