Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     gregory.greenman@intel.com
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 04/15] wifi: mac80211: add an element parsing unit test
References: <20230827110532.348304-1-gregory.greenman@intel.com>
        <20230827135854.333bc75df13f.I0ddfeb6a88a4d89e7c7850e8ef45a4b19b5a061a@changeid>
Date:   Mon, 04 Sep 2023 18:23:31 +0300
In-Reply-To: <20230827135854.333bc75df13f.I0ddfeb6a88a4d89e7c7850e8ef45a4b19b5a061a@changeid>
        (gregory greenman's message of "Sun, 27 Aug 2023 14:05:21 +0300")
Message-ID: <877cp6q7ws.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

gregory.greenman@intel.com writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> Add a unit test for the parsing of a fragmented sta profile
> sub-element inside a fragmented multi-link element.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> ---
>  net/mac80211/Kconfig        |  11 ++++
>  net/mac80211/Makefile       |   2 +
>  net/mac80211/tests/Makefile |   3 ++
>  net/mac80211/tests/elems.c  | 101 ++++++++++++++++++++++++++++++++++++
>  net/mac80211/tests/module.c |  10 ++++
>  net/mac80211/util.c         |   3 ++
>  6 files changed, 130 insertions(+)
>  create mode 100644 net/mac80211/tests/Makefile
>  create mode 100644 net/mac80211/tests/elems.c
>  create mode 100644 net/mac80211/tests/module.c
>
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> index 51ec8256b7fa..037ab74f5ade 100644
> --- a/net/mac80211/Kconfig
> +++ b/net/mac80211/Kconfig
> @@ -57,6 +57,17 @@ endif
>  comment "Some wireless drivers require a rate control algorithm"
>  	depends on MAC80211 && MAC80211_HAS_RC=n
>  
> +config MAC80211_KUNIT_TEST
> +	tristate "KUnit tests for mac80211" if !KUNIT_ALL_TESTS
> +	depends on KUNIT
> +	depends on MAC80211
> +	default KUNIT_ALL_TESTS
> +	depends on !KERNEL_6_2
> +	help
> +	  Enable this option to test mac80211 internals with kunit.
> +
> +	  If unsure, say N.

Just wanted to say that this is great. Hopefully we will have more tests
in the future.

But what's KERNEL_6_2? I tried to grep for that in wireless-next but
didn't find anything.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches