Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp3316503rdb; Thu, 7 Sep 2023 10:48:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQhvJlf3XdFo/ZAE5nBaWywH0WiwlbqkD6pDCLW+sTU2xzj/0rf4nj2z33wpuwlBFErxTI X-Received: by 2002:a17:903:245:b0:1c1:fe87:f550 with SMTP id j5-20020a170903024500b001c1fe87f550mr393935plh.7.1694108933948; Thu, 07 Sep 2023 10:48:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694108933; cv=none; d=google.com; s=arc-20160816; b=AQbfkrZFaAA50AqDahJrsQJ+eO0BXkEITU4OJeFVmINn+zJQ6Vdrf0hiq0s1PCVYZu wxzyiV8mjZAPtvQW4AX66ebfeyQcOt+j2H6+CadV1joiuRwF7PKcrgqaI14PX1J+NrNc ffBzUh4pkaQXl5bduutADwY1Fmlok//lPyNNF3HLiEZksn7SPJqQQ280K4qkThMlenWR Gml38DRlckS5f/twRGRgGmQxw04hI/vSuwODZwlHsfsNq+j6M/kqPxa8F0uqThzNNdCG QqjCnIOZ0OELtw0yl1jQLFKNaeLdnavdsGDZQ0PH85Gkenre1wIhuF10X0+xNamj7Cmp wtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+WEiKdF3c5N+SUZ5CfMRo5zGi8mopa3Bem+/1n5Z3NU=; fh=bBn6zprorfUX84Mt8hN9PgSHXeK40VZziIAorVPWGdI=; b=grC4q4ZayTOy8yzyDg0sqZdPLvbKJc3DAiEMNj03ST1SWADtGIEBUVJE3YsoUP+ZzJ h5j0Vbfe5ud2MYbAyQgJW/v3c+N0RIktH965IRFX8M6weRNryTkdjoR6tdVJEgREJvAO AKZdmOw4X3HBbb8p+Znoyvn10F+b2Lg/vYUBvwNnD5WsEsS1dCexgvjPo0WoUTmAJxoL PDgfgyFjU2yeMVV3yWONaxpc+ev3Dmj1WxsCYvbvraCs5fnO79YDw7ads9x19IgI2Q38 lnsHKp8jbJSdgWVOnrRzTriqhXDyQV5RDsIpDW7e4JHP6iVxUai2uLAjMMb+AmeIuh8d jbpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ik24-20020a170902ab1800b001b8c6f80ddbsi73741plb.105.2023.09.07.10.48.44; Thu, 07 Sep 2023 10:48:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbjIGQdQ (ORCPT + 53 others); Thu, 7 Sep 2023 12:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239488AbjIGQcd (ORCPT ); Thu, 7 Sep 2023 12:32:33 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A7055FFE for ; Thu, 7 Sep 2023 09:31:54 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeA5A-00048z-1X; Thu, 07 Sep 2023 10:09:44 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qeA59-004bse-8X; Thu, 07 Sep 2023 10:09:43 +0200 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qeA58-008rFV-DT; Thu, 07 Sep 2023 10:09:42 +0200 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Kalle Valo , Ping-Ke Shih , Yanik Fuchs , Sascha Hauer , stable@vger.kernel.org Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM Date: Thu, 7 Sep 2023 10:09:42 +0200 Message-Id: <20230907080942.2111305-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The MAC address is stored at offset 0x107 in the EEPROM, like correctly stated in the comment. Add a two bytes reserved field right before the MAC address to shift it from offset 0x105 to 0x107. With this the MAC address returned from my RTL8723du wifi stick can be correctly decoded as "Shenzhen Four Seas Global Link Network Technology Co., Ltd." Signed-off-by: Sascha Hauer Reported-by: Yanik Fuchs Cc: stable@vger.kernel.org --- drivers/net/wireless/realtek/rtw88/rtw8723d.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.h b/drivers/net/wireless/realtek/rtw88/rtw8723d.h index 3642a2c7f80c9..2434e2480cbe2 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.h +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.h @@ -46,6 +46,7 @@ struct rtw8723du_efuse { u8 vender_id[2]; /* 0x100 */ u8 product_id[2]; /* 0x102 */ u8 usb_option; /* 0x104 */ + u8 res5[2]; /* 0x105 */ u8 mac_addr[ETH_ALEN]; /* 0x107 */ }; -- 2.39.2