Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock_rate
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230904232346.34991-1-rand.sec96@gmail.com>
References: <20230904232346.34991-1-rand.sec96@gmail.com>
To:     Rand Deeb <rand.sec96@gmail.com>
Cc:     Michael Buesch <m@bues.ch>, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org, deeb.rand@confident.ru,
        lvc-project@linuxtesting.org, voskresenski.stanislav@confident.ru,
        Rand Deeb <rand.sec96@gmail.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169406641403.3946078.14931132240535951245.kvalo@kernel.org>
Date:   Thu,  7 Sep 2023 06:00:15 +0000 (UTC)
Precedence: bulk

Rand Deeb <rand.sec96@gmail.com> wrote:

> In ssb_calc_clock_rate(), there is a potential issue where the value of
> m1 could be zero due to initialization using clkfactor_f6_resolv(). This
> situation raised concerns about the possibility of a division by zero
> error.
> 
> We fixed it by following the suggestions provided by Larry Finger
> <Larry.Finger@lwfinger.net> and Michael Büsch <m@bues.ch>. The fix
> involves returning a value of 1 instead of 0 in clkfactor_f6_resolv().
> This modification ensures the proper functioning of the code and
> eliminates the risk of division by zero errors.
> 
> Signed-off-by: Rand Deeb <rand.sec96@gmail.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> Acked-by: Michael Büsch <m@bues.ch>

Patch applied to wireless-next.git, thanks.

e0b5127fa134 ssb: Fix division by zero issue in ssb_calc_clock_rate

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230904232346.34991-1-rand.sec96@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches