Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     <Prasurjya.Rohansaikia@microchip.com>
Cc:     <linux-wireless@vger.kernel.org>, <Ajay.Kathat@microchip.com>,
        <claudiu.beznea@microchip.com>
Subject: Re: [PATCH v2] wifi: wilc1000: Added back-off algorithm to balance
 tx queue packets.
References: <20230816162259.33342-1-prasurjya.rohansaikia@microchip.com>
        <871qfuvwzd.fsf@kernel.org>
        <DM4PR11MB633677755A94860F2E1B6449F4EEA@DM4PR11MB6336.namprd11.prod.outlook.com>
Date:   Fri, 08 Sep 2023 11:18:42 +0300
In-Reply-To: <DM4PR11MB633677755A94860F2E1B6449F4EEA@DM4PR11MB6336.namprd11.prod.outlook.com>
        (Prasurjya Rohansaikia's message of "Thu, 7 Sep 2023 17:01:35 +0000")
Message-ID: <87cyytm61p.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

<Prasurjya.Rohansaikia@microchip.com> writes:

> <Prasurjya.Rohansaikia@microchip.com> writes:
>
>> From: Prasurjya Rohan Saikia <prasurjya.rohansaikia@microchip.com>
>>
>> Added an algorithm to backoff the Tx Task when low memory scenario is
>> triggered at firmware. During high data transfer from host, the firmware
>> runs out of VMM memory, which is used to hold the frames from the host.
>> So added flow control to delay the transmit from host side when there is
>> not enough space to accomodate frames in firmware side.
>>
>> Signed-off-by: Prasurjya Rohan Saikia <prasurjya.rohansaikia@microchip.com>
>
> [...]
>
>> -             } while (ret == WILC_VMM_ENTRY_FULL_RETRY && !wl->close);
>> +                     if (ret != WILC_VMM_ENTRY_FULL_RETRY)
>> +                             break;
>> +                     /* Back off from sending packets for some time.
>> +                      * schedule_timeout will allow RX task to run and free
>> +                      * buffers. Setting state to TASK_INTERRUPTIBLE will
>> +                      * put the thread back to CPU running queue when it's
>> +                      * signaled even if 'timeout' isn't elapsed. This gives
>> +                      * faster chance for reserved SK buffers to be freed
>> +                      */
>> +                     set_current_state(TASK_INTERRUPTIBLE);
>> +                     schedule_timeout(msecs_to_jiffies
>> +                                      (TX_BACKOFF_WEIGHT_MS));
>> +             } while (!wl->close);
>
> Why not msleep_interruptible()?
>
> Thanks you for your suggestion. However, I decided to proceed with
> schedule_timeout_interruptible() after testing and I will resubmit the patch. 

You need to provide more information than that.

Please quote your emails properly and don't send HTML emails, our lists
automaticall drop all HTML mail.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches