Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Sep 2023 13:36:55 +0200
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>, Yanik Fuchs <Yanik.fuchs@mbv.ch>
Subject: Re: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
Message-ID: <20230908113655.GF637806@pengutronix.de>
References: <20230907071614.2032404-1-s.hauer@pengutronix.de>
 <bed0e0cacc44476582fc58180d77519c@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bed0e0cacc44476582fc58180d77519c@realtek.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Sep 08, 2023 at 12:23:13AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Thursday, September 7, 2023 3:16 PM
> > To: linux-wireless@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih <pkshih@realtek.com>; Yanik
> > Fuchs <Yanik.fuchs@mbv.ch>
> > Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
> > 
> > The MAC address is stored at offset 0x107 in the EEPROM, like correctly
> > stated in the comment. Add a two bytes reserved field right before the
> > MAC address to shift it from offset 0x105 to 0x107.
> > 
> > With this the MAC address returned from my RTL8723du wifi stick can be
> > correctly decoded as "Shenzhen Four Seas Global Link Network Technology
> > Co., Ltd."
> 
> With this correctness, my stick can be recognized as: 
> " Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter"

It should be recognized like this also without this patch, but with this
patch the MAC address should be read correctly.

> 
> Should it add a Fixes tag? 
> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")

Yes, I forgot this. Kalle, can you add it once again while applying?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |