Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Kalle Valo <kvalo@kernel.org>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     linux-wireless@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next] wifi: ti/wlcore: Convert to platform remove
 callback returning void
References: <20230912171249.755901-1-u.kleine-koenig@pengutronix.de>
Date:   Tue, 12 Sep 2023 20:23:18 +0300
In-Reply-To: <20230912171249.755901-1-u.kleine-koenig@pengutronix.de> ("Uwe
        =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Tue, 12 Sep 2023 19:12:49
 +0200")
Message-ID: <87sf7jcnll.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de> writes:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code.  However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> wlcore_remove() returned zero unconditionally. With that converted to
> return void instead, the wl12xx and wl18xx driver can be converted to
> .remove_new trivially.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/net/wireless/ti/wl12xx/main.c   | 6 +++---
>  drivers/net/wireless/ti/wl18xx/main.c   | 2 +-
>  drivers/net/wireless/ti/wlcore/main.c   | 6 ++----
>  drivers/net/wireless/ti/wlcore/wlcore.h | 2 +-
>  4 files changed, 7 insertions(+), 9 deletions(-)

wireless patches go to wireless-next, not net-next. But no need to
resend because of this.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes