Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <365caa2a20678c1c1c08c947a2141b40320553c6.camel@sipsolutions.net>
Subject: Re: [PATCH v2 1/3] wifi: cfg80211: export DFS CAC time and usable
 state helper functions
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org,
        Jeff Johnson <quic_jjohnson@quicinc.com>
Date:   Wed, 13 Sep 2023 12:17:38 +0200
In-Reply-To: <511f23be-7b7b-42d9-9c3e-25edfa5d7323@quicinc.com>
References: <20230912051857.2284-1-quic_adisi@quicinc.com>
         <20230912051857.2284-2-quic_adisi@quicinc.com>
         <f436ea028da7b016241f307348286be6cfe7df65.camel@sipsolutions.net>
         <511f23be-7b7b-42d9-9c3e-25edfa5d7323@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-09-13 at 15:46 +0530, Aditya Kumar Singh wrote:
> On 9/13/23 14:58, Johannes Berg wrote:
> > On Tue, 2023-09-12 at 10:48 +0530, Aditya Kumar Singh wrote:
> > > cfg80211 has cfg80211_chandef_dfs_usable() function to know whether
> > > at least one channel in the chandef is in usable state or not. Also,
> > > cfg80211_chandef_dfs_cac_time() function is there which tells the CAC
> > > time required for the given chandef.
> > >=20
> >=20
> > Should we really export the time function just for a debug messages?
> > That seems like a waste of space?
> >=20
> Yes absolutely. But actually as a follow up of this patch, we have=20
> Background DFS patch in pipeline which requires us to send the CAC time=
=20
> to firmware. So its actually needed there. And may be once we do this,=
=20
> other drivers also may start using this?

OK, fair enough :)

johannes