Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <7d4eae1a38e3791e467bf29195abd781e43789ce.camel@sipsolutions.net>
Subject: Re: [PATCH 1/1] cfg80211: Allow AP/P2PGO to indicate port
 authorization to peer STA/P2PClient
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Vinayak Yadawad <vinayak.yadawad@broadcom.com>
Cc:     linux-wireless@vger.kernel.org, jithu.jance@broadcom.com
Date:   Wed, 13 Sep 2023 11:31:01 +0200
In-Reply-To: <85614ee38fd3f68ade1810c2be0863c45c22fef1.1694499025.git.vinayak.yadawad@broadcom.com>
References: <85614ee38fd3f68ade1810c2be0863c45c22fef1.1694499025.git.vinayak.yadawad@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-09-12 at 12:24 +0530, Vinayak Yadawad wrote:
> In 4way handshake offload, cfg80211_port_authorized
> enables driver to indicate successful 4way handshake to cfg80211 layer.
> Currently this path of port authorization is restricted to
> interface type NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT.
> This patch extends the support for NL80211_IFTYPE_AP and
> NL80211_IFTYPE_P2P_GO interfaces to authorize peer STA/P2P_CLIENT,
> whenever authentication is offloaded on the AP/P2P_GO interface.

It seems that this should at least also come with documentation updates
in nl80211.h?

And proper code indentation :-)

> - * @bssid: the BSSID of the AP
> + * @peer_mac: BSSID of the AP/P2P GO in case of STA/GC or STA/GC macaddr=
ess in
> + * case of AP/P2P GO

And "peer_addr" is probably better? Technically, after all, it's the
"MAC address" (which you also spelled wrong), but the "MAC" itself :)

johannes