Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <5a98910aa4577e784e17ef6e0201dc57b11a5c24.camel@sipsolutions.net>
Subject: Re: [PATCH v6 2/3] wifi: mac80211: allow userspace to enable driver
 control of MU-EDCA
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Muna Sinada <quic_msinada@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 13 Sep 2023 11:44:08 +0200
In-Reply-To: <1682960363-15452-2-git-send-email-quic_msinada@quicinc.com>
References: <1682960363-15452-1-git-send-email-quic_msinada@quicinc.com>
         <1682960363-15452-2-git-send-email-quic_msinada@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

>=20
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -376,6 +376,7 @@ enum ieee80211_bss_change {
>  	BSS_CHANGED_FILS_DISCOVERY      =3D 1<<30,
>  	BSS_CHANGED_UNSOL_BCAST_PROBE_RESP =3D 1<<31,
>  	BSS_CHANGED_EHT_PUNCTURING	=3D BIT_ULL(32),
> +	BSS_CHANGED_DYNAMIC_MU_EDCA	=3D BIT_ULL(33),

This is missing documentation.

> + * @dyn_muedca_enabled: whether to enable or disable driver control of M=
U-EDCA
> + *	parameters. If set to zero, driver dynamically updating parameters is
> + *	disabled; if set to 1, driver dynamically updating parameters is enab=
le
>   */
>  struct ieee80211_bss_conf {
>  	struct ieee80211_vif *vif;
> @@ -776,6 +780,8 @@ struct ieee80211_bss_conf {
>  	bool eht_su_beamformer;
>  	bool eht_su_beamformee;
>  	bool eht_mu_beamformer;
> +
> +	int dyn_muedca_enabled;

why int with 0/1 rather than bool like the others?

> @@ -1465,6 +1465,11 @@ static int ieee80211_start_ap(struct wiphy *wiphy,=
 struct net_device *dev,
>  		changed |=3D BSS_CHANGED_UNSOL_BCAST_PROBE_RESP;
>  	}
> =20
> +	if (link_conf->dyn_muedca_enabled !=3D params->dyn_muedca_enable) {
> +		link_conf->dyn_muedca_enabled =3D params->dyn_muedca_enable;
> +		changed |=3D BSS_CHANGED_DYNAMIC_MU_EDCA;
> +	}

This doesn't seem right ... think about it.

johannes