Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3561946rdb; Wed, 13 Sep 2023 16:29:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKo/LsevCfJIXPYNGzM3BDM5B/uTxOIgVGhFJj+X5IBpqDCnumYmHGP5l0NeDc8b4LQSSN X-Received: by 2002:aa7:88c8:0:b0:68a:3e68:f8ab with SMTP id k8-20020aa788c8000000b0068a3e68f8abmr4977783pff.14.1694647752679; Wed, 13 Sep 2023 16:29:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694647752; cv=none; d=google.com; s=arc-20160816; b=DSZRyOoS0x67ejbz6g4GiTOsb7U23Kf0dG5YRu/z60x4fZUyVixeEEoOJoi8fdQ/EN 9Yhx1kl0IuNNmwXXI3p1PfCVbxF+XFGYOp9S6W7WxWqH4D0OmjM6Q3UDG0JOAjGePALQ T8UNbTVw0oLpyQspWyivwGSPULp2KI4KOm1G252F/ATwnz4CTvtVHq13BuZwOoGYdM3p mlWmT8h7mqDwS/Ao/6CWh8d8XouxupEKCidiUMtAbZg0Ws81ppPOVIx2CFRXfEAhPdc2 JDlo0eGyRyUxy05i+5Sioi+WfRfUhFkXnqnuGE8Gt5njUpwLtUSel/lL0mIepVJdYvcg CSqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dQ29BPoWPwdnF8v9flAhGQv3+Ng0/UjMuBrnfQnH+kA=; fh=T6y/oS++RIYqEuqxIx2phDO2xU+34wOH47oi8kJGCZk=; b=mtxA+B8qk9k6DPBLxg+Vqu/kngNdV0Zy6azvguAoPkcd0nZTzciRSKtHwuwFOsSYvo 0MwvMqyQrPDPijh1J97NFVlzUgsl0/0+bL4WAPuQjam4bOTIcJt9cqF1Du17sZf8uSvF SRQbBPbLVN7cz8EXYA6NeZ6O+Ct1Tpq9841/D3KL19zVivDMj6xym0T9D2VCXzbG6gdI Itu8lOn4Q6QyELiHnje4Q0u4vbvn9Ip4te1a/VHxcyhT0A5WjQ77lTTwQpmxyykGA5/Z dqMj9yYqGP/9d4/efGSrd1xlma22ArL8Q1ImdxN8zQY6lVmg+ln8V30SqlfOYiICfy+U HOHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=j5hYXdw7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id o21-20020a639215000000b0057790a53ce8si197181pgd.152.2023.09.13.16.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 16:29:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=j5hYXdw7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8D72081BBA38; Wed, 13 Sep 2023 04:58:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240605AbjIML6K (ORCPT + 56 others); Wed, 13 Sep 2023 07:58:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240608AbjIML6J (ORCPT ); Wed, 13 Sep 2023 07:58:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6938219A8 for ; Wed, 13 Sep 2023 04:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694606285; x=1726142285; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ii9/Kw5cZvBrFj4DTdipmjFe5erCypq59xbQv+xOM58=; b=j5hYXdw7NdFZqMUvDafM6IhhkppytKqAZz4tFnWjOEioIc3o3WZaOLnD yWgZkTNlMBsK/ZfIZ/cUYHBtkypWt8bys7aRsYyCkKhP5RU55woRzEbH7 iP92VehU3AD0e+aeT+sHrPcW53p4vl0N0t5m1sgfZmTmHI8fOlkGwpVIv e14iABMameo9jS1QeGQsQJfFMgi31aEzgtKGyCFFbGRq7E9jWLghPk6vF vF1V/frr0oABhvudbNeekX5iZQEkZuceH9hQ7yo4Cb7COL33dtfCJ/ryh VWPU9iMYT9yzZDgX5RnfYq4xl/tqRgNi/+J3Bp7pfo5A3KY9HSoJsSD14 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="368903106" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="368903106" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 04:57:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="737470993" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="737470993" Received: from ggreenma-mobl2.jer.intel.com ([10.13.17.40]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 04:57:42 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach , Gregory Greenman Subject: [PATCH 15/15] wifi: iwlwifi: mvm: add a debug print when we get a BAR Date: Wed, 13 Sep 2023 14:56:51 +0300 Message-Id: <20230913145231.913e989a1751.I6bff9020e339d91b61b5ad6aede27bcf8c7e6819@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230913115651.190558-1-gregory.greenman@intel.com> References: <20230913115651.190558-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 04:58:12 -0700 (PDT) From: Emmanuel Grumbach Getting a BAR can be an explanation if we're chasing packet loss. Add a print with the relevant debug level in that code path. Signed-off-by: Emmanuel Grumbach Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c index 42d69f557e71..041afc97a911 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c @@ -2803,6 +2803,9 @@ void iwl_mvm_rx_bar_frame_release(struct iwl_mvm *mvm, struct napi_struct *napi, tid)) goto out; + IWL_DEBUG_DROP(mvm, "Received a BAR, expect packet loss: nssn %d\n", + nssn); + iwl_mvm_release_frames_from_notif(mvm, napi, baid, nssn, queue, 0); out: rcu_read_unlock(); -- 2.38.1