Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <d7d6cbf5ea15bca1aa2a127029e249e154eb863a.camel@sipsolutions.net>
Subject: Re: [PATCH v3 2/9] wifi: cfg80211: save Power Spectral Density
 (PSD) of the regulatory rule
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>,
        Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc:     linux-wireless@vger.kernel.org,
        Jeff Johnson <quic_jjohnson@quicinc.com>
Date:   Thu, 14 Sep 2023 09:18:12 +0200
In-Reply-To: <e79cae30-0d38-1d01-2ab2-943ad191149a@quicinc.com>
References: <20230315132904.31779-1-quic_adisi@quicinc.com>
         <20230315132904.31779-3-quic_adisi@quicinc.com>
         <4cb3e92530d3f4db3b414e2a7536a0f01b765c4d.camel@sipsolutions.net>
         <e79cae30-0d38-1d01-2ab2-943ad191149a@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-09-14 at 11:45 +0800, Wen Gong wrote:
> On 9/13/2023 10:58 PM, Johannes Berg wrote:
> > On Wed, 2023-03-15 at 18:58 +0530, Aditya Kumar Singh wrote:
> >=20
> > > @@ -8650,6 +8660,14 @@ static int parse_reg_rule(struct nlattr *tb[],
> > >  =20
> > >   	reg_rule->flags =3D nla_get_u32(tb[NL80211_ATTR_REG_RULE_FLAGS]);
> > >  =20
> > > +	if (reg_rule->flags & NL80211_RRF_PSD) {
> > > +		if (!tb[NL80211_ATTR_POWER_RULE_PSD])
> > > +			return -EINVAL;
> > > +
> > > +		reg_rule->psd =3D
> > > +			nla_get_s8(tb[NL80211_ATTR_POWER_RULE_PSD]);
> > > +	}
> > Wait ... I'm not sure why we've been adding stuff to this recently, but
> > anyway, this part should only be used by CRDA which is deprecated
> > anyway?
> >=20
> > So I'd say we shouldn't touch any of the code under #ifdef
> > CONFIG_CFG80211_CRDA_SUPPORT any more since CRDA will not continue to
> > developed with any updates here.
> >=20
> > johannes
> Oh, I will remove the change in parse_reg_rule() in next version, because
> you asked me to add change in 2=20
> functions(nl80211_put_regdom()/nl80211_msg_put_channel())
> below, but I added change in one more function(parse_reg_rule()).
>=20

Yes, we should have visibility on the output - but I don't think we ever
expect the input to carry it this way via nl80211 since that's long
deprecated in favour of the kernel loading it as a 'firmware' file.

johannes