Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <ac5cdf25-7dc5-43ac-8cf9-8997dfd9e07e@quicinc.com>
Date:   Thu, 14 Sep 2023 09:21:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: ath10k: drop HTT_DATA_TX_STATUS_DOWNLOAD_FAIL
Content-Language: en-US
To:     Dmitry Antipov <dmantipov@yandex.ru>
CC:     Kalle Valo <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>,
        <lvc-project@linuxtesting.org>, <ath10k@lists.infradead.org>
References: <18eac255-720a-488e-882e-b79f098aba65@quicinc.com>
 <20230914160744.155903-1-dmantipov@yandex.ru>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230914160744.155903-1-dmantipov@yandex.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/14/2023 9:07 AM, Dmitry Antipov wrote:
> According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from
> 'enum htt_data_tx_status' is never actually used by the
> firmware code and so may be dropped, with the related
> adjustment to 'ath10k_htt_rx_tx_compl_ind()'.
> 
> Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>

> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> ---
>   drivers/net/wireless/ath/ath10k/htt.h    | 3 +--
>   drivers/net/wireless/ath/ath10k/htt_rx.c | 1 -
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
> index 7b24297146e7..c80470e8886a 100644
> --- a/drivers/net/wireless/ath/ath10k/htt.h
> +++ b/drivers/net/wireless/ath/ath10k/htt.h
> @@ -880,8 +880,7 @@ enum htt_data_tx_status {
>   	HTT_DATA_TX_STATUS_OK            = 0,
>   	HTT_DATA_TX_STATUS_DISCARD       = 1,
>   	HTT_DATA_TX_STATUS_NO_ACK        = 2,
> -	HTT_DATA_TX_STATUS_POSTPONE      = 3, /* HL only */
> -	HTT_DATA_TX_STATUS_DOWNLOAD_FAIL = 128
> +	HTT_DATA_TX_STATUS_POSTPONE      = 3 /* HL only */
>   };
>   
>   enum htt_data_tx_flags {
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index 438b0caaceb7..b261d6371c0f 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -2964,7 +2964,6 @@ static void ath10k_htt_rx_tx_compl_ind(struct ath10k *ar,
>   		break;
>   	case HTT_DATA_TX_STATUS_DISCARD:
>   	case HTT_DATA_TX_STATUS_POSTPONE:
> -	case HTT_DATA_TX_STATUS_DOWNLOAD_FAIL:
>   		tx_done.status = HTT_TX_COMPL_STATE_DISCARD;
>   		break;
>   	default: