Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6095575rdb; Mon, 18 Sep 2023 04:15:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnTFIMzXKjKp28FabDaJc+D0DAiJLOgwdK+1S09+ZwMAcTdPXZvyqhGP0vbnOTwzHjMWAU X-Received: by 2002:a17:90a:17cd:b0:268:e43a:dbfd with SMTP id q71-20020a17090a17cd00b00268e43adbfdmr8378025pja.1.1695035750452; Mon, 18 Sep 2023 04:15:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695035750; cv=none; d=google.com; s=arc-20160816; b=MM6J1GWn84D1gisxSxkL8vuXaU6mIrPdglKewQ1VIic5vxE1USegDiBMQcuEEkjopT yF3n/GLyj6pxlEqc0dl4AM2296DEjXXuWxoXdPR+1L7vTM3rFyhqe4tydTMPKW2uhDuv fp/6K9KYUnL/xFPKSY1efWBYzU2QmIQLyXpvIsw0vrwxkJNmsQyLSzcLPpqS4uXc2LHu WY45xAJIMi5/4E57qoEx2SDmQezj8hbX2eMwvpPJ1XZ35M5qPm9BKbkUrOfk8JHiXBQU Sc9xdzAsU/jmSuM3akdGPhS/sZqmNJ0Udeo+hphJCOEnroHn5UADS1G0ZKxC42NAQfXD 56zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=ec02TSjdTHuIcXUnSvMKpVMkNA8DWplDTKJsNzmmkhs=; fh=frygSLqxgplnjw7TXlUX1vNd+GDUTYJkp2F+c+t3OEk=; b=bnsgb4vqFOhDhiSfVM43ee8/DcECUJTCHzk+JDvGWbbEgV59M3XbCQeShYMRwZNXfk 0Qjkjhp6vgFgqUpmY6lklXyKyNkSGRClsAPj3d75Rzlx0YPfU4tf5N/aA0Yd92KwhTZf mO6Am6x9jV7DqwFJ6/DRWENMIGdH5a34T1Uy+nUl+IqtktFnog1CXPII3TfJlyjvCIjo lFtq7+RKGPr+yUcqgVXyqCf9NkTze/ZxZ+it6dkck6rNolkJuvBM/ajIgIHFLksuaQeM RJijeu/EPCLp4P/KKwqw5b5tTPmCfRxk+z52OvxKwy/e8L1gnOxT3ptvxKbcZrlNAONi rxgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=xovCkaZ5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ge4-20020a17090b0e0400b0026335941736si7070834pjb.144.2023.09.18.04.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 04:15:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=xovCkaZ5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8BFD080B1312; Mon, 18 Sep 2023 00:53:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240213AbjIRHw2 (ORCPT + 57 others); Mon, 18 Sep 2023 03:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240551AbjIRHwI (ORCPT ); Mon, 18 Sep 2023 03:52:08 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 786AB30C4 for ; Mon, 18 Sep 2023 00:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ec02TSjdTHuIcXUnSvMKpVMkNA8DWplDTKJsNzmmkhs=; t=1695023316; x=1696232916; b=xovCkaZ5eVjuLEzhQcqwfsvND1utKgpDXLXWoMb9Pkv4zpp gJRTcOD7EFNbjTGqU/D5bJPYxZBgxtNJtOmLhh/hnvrQdZ8BXKGkkfx/Mn+sdeck59UM4QwlA0FOn 6xgnTV9eeaT9CYUPsyHIxRMmd/zqmXj29usA4R5vQAUyNoC7BvXHR1q8RJzuHvx+4Gv97Y+NUncRP CfetjcGBxHV0WfQrYtnnJFKPXbrf4F+dwFRAYGEOSv+SaEp/aIS31f7aaleknHS1QF5yqCOJZNG4O KRAjQkx7VIVmVGI73Qf/H6Hb8a0lOwgT6BhBikNL9S8NvrhXnjcOvMQSPDW4u8HQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qi8zZ-006waz-1W; Mon, 18 Sep 2023 09:48:25 +0200 Message-ID: <09e4413a307a8614534af4eb08e007d897114d23.camel@sipsolutions.net> Subject: Re: [PATCH v2 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient From: Johannes Berg To: Jeff Johnson , Vinayak Yadawad Cc: linux-wireless@vger.kernel.org, jithu.jance@broadcom.com Date: Mon, 18 Sep 2023 09:48:24 +0200 In-Reply-To: <75476a44-e85a-4fba-ae02-c15f1f051bdd@quicinc.com> References: <75476a44-e85a-4fba-ae02-c15f1f051bdd@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 18 Sep 2023 00:53:22 -0700 (PDT) On Fri, 2023-09-15 at 12:11 -0700, Jeff Johnson wrote: > On 9/14/2023 10:17 PM, Vinayak Yadawad wrote: > > In 4way handshake offload, cfg80211_port_authorized enables driver > > to indicate successful 4way handshake to cfg80211 layer. Currently > > this path of port authorization is restricted to interface type > > NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch > > extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO > > interfaces to authorize peer STA/P2P_CLIENT, whenever authentication > > is offloaded on the AP/P2P_GO interface. > >=20 > > Signed-off-by: Vinayak Yadawad > > --- >=20 > v1->v2 change log is missing > can you provide that as a separate message Or just fix it with v3, this doesn't apply ... Also please indent the documentation per what you see there (tab). johannes