Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp152990rdb; Mon, 18 Sep 2023 10:44:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxZepHwdGsxNRPxn91mzFnYdlHr5EgJ+tfIXboC5tJkXu8Nkc37fDQ3jRe53EdpaBUOXxw X-Received: by 2002:a05:6a00:2484:b0:68c:70f:ee3f with SMTP id c4-20020a056a00248400b0068c070fee3fmr10526599pfv.13.1695059078593; Mon, 18 Sep 2023 10:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695059078; cv=none; d=google.com; s=arc-20160816; b=kD34hOeE3Ifs11rn4ydP55Z+wljb21sEt4Uq9GEmbNrBRUuq89qCMt0D3SEpny9xkA 9HYHw2M7cS0fGLPQZdhIc7TSM/U0AZ84y5SyEMHYNXJ3XN+qb677uVKLPKyyfhv3Q4Bj T+7FIy65I1HcwnfatybYz8XOhNuArft6E1L4OcGOfrIz9dXUKP9Fa7I8d+slQh/FDoth NPvXR1JjMI23A/ibpjRxixk+Uy6ularIeWeWpXX0Caa4QvA7ZHCGpAHySOBSokEbQEpX hTVTe9JcgSSgVD/g/zVXPcXdFx8AGXOueM/Le5mp9tiV2xr0FwKqrjVNJSB2PqYEJd54 9KMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=mudOpo4N0y+24OzOWCHzESEanF1WV6rQJuDiZCyitpg=; fh=sLao5R+6fO68FRMqo6vmqR5M4UryRyYBsV4G/HWqHYM=; b=ubCw7O6h/47XcfEOcg4PYzmx7webF1hkAaJgGy1tzs5Eb5YqJZOWtj1S6ooRdYzCxl 3HFXdPODDw+PIHKfRTPwu9Tfu9pfA57RibEa0yxgXfO0xecGWZWb52PwZ0mmmcNmMkmU HVg+sb4bXCfeDcB5MSAfm+wp/sQlATYUPvOml9RwfnaUR9u+h1LvplE5T3whXJJGJYQd FIr+Boufyo1xV6zTOJVNTbNhzcsSBvvwjkjOzWAnx/RHWx8TUyutvH6VeladVyjSzShb 9eIMVSlmKuQm+i8CmrcRxVO7oE2gG1mSCRU917fZOkhkNPcu1lB26IkebrZvKHj6KGgZ B9Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oujQRKR3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id ch12-20020a056a00288c00b0068a52819fd2si8389564pfb.331.2023.09.18.10.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 10:44:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oujQRKR3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9923B803B3A4; Mon, 18 Sep 2023 10:02:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbjIRRCk (ORCPT + 57 others); Mon, 18 Sep 2023 13:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjIRRCh (ORCPT ); Mon, 18 Sep 2023 13:02:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E4DB8E; Mon, 18 Sep 2023 10:02:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18049C32783; Mon, 18 Sep 2023 14:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695047303; bh=cVt3BSeAbCgVpGd6WsEDtgkVPihUYdejvLe8R1O+i1g=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oujQRKR3JJRDQPQnBYyL9Mg1kpOvs+cB33amTS3eFRjjqd1ZG90xTJeuoCIljLWSh 77WZKkUjudUGRZIgu3zj8S3mVt8EOKLZYDjtT05yhKmY7IfiIxZLbLhCC8AruV3ojg UMhQ8RsJVZBstLuk0jUp5BH0orKiLeSIezkoh/b26DFLv6yZlsFbPy+66G54AQ3sO5 6wfuro4Idxl2oYwUqrRAifR5IZOQdnnjV/JhDh9fm1EKl4Ox8JjFOAuH26AFjEs5pY zOds9b6vC4jPfASTBfTap1B9zqOOL9Fn2sbFEgLN7ARf0r6uZ12mYb7JLJwRvgSpyT dZudbPpR/4joA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/2] wifi: cw1200: Avoid processing an invalid TIM IE From: Kalle Valo In-Reply-To: <20230831-ieee80211_tim_ie-v3-1-e10ff584ab5d@quicinc.com> References: <20230831-ieee80211_tim_ie-v3-1-e10ff584ab5d@quicinc.com> To: Jeff Johnson Cc: , =?utf-8?q?Toke_H?= =?utf-8?q?=C3=B8iland-J=C3=B8rgensen?= , "Christian Lamparter" , Stanislaw Gruszka , "Helmut Schaa" , Ping-Ke Shih , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kees Cook , , , , Jeff Johnson User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169504729816.740666.17271538419199878496.kvalo@kernel.org> Date: Mon, 18 Sep 2023 14:28:19 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 18 Sep 2023 10:02:37 -0700 (PDT) Jeff Johnson wrote: > While converting struct ieee80211_tim_ie::virtual_map to be a flexible > array it was observed that the TIM IE processing in cw1200_rx_cb() > could potentially process a malformed IE in a manner that could result > in a buffer over-read. Add logic to verify that the TIM IE length is > large enough to hold a valid TIM payload before processing it. > > Signed-off-by: Jeff Johnson Patch applied to wireless-next.git, thanks. b7bcea9c27b3 wifi: cw1200: Avoid processing an invalid TIM IE -- https://patchwork.kernel.org/project/linux-wireless/patch/20230831-ieee80211_tim_ie-v3-1-e10ff584ab5d@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches