Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <66901daa-0c69-4a22-82fd-e66f8b6a011b@quicinc.com>
Date:   Tue, 19 Sep 2023 12:57:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/7] wifi: ath12k: build 6 GHz regd based on vdev type and
 6 GHz power type
Content-Language: en-US
To:     Aishwarya R <quic_aisr@quicinc.com>, <ath12k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>
References: <20230919071724.15505-1-quic_aisr@quicinc.com>
 <20230919071724.15505-3-quic_aisr@quicinc.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230919071724.15505-3-quic_aisr@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/19/2023 12:17 AM, Aishwarya R wrote:
> During bootup, WMI_REG_CHAN_LIST_CC_EXT_EVENTID event sent from firmware
> at an early stage and it expects the 6 GHz power type for 6 GHz reg rules.

what is "it"?

> As power mode is not defined at this point host selects IEEE80211_REG_UNSET_AP
> as default mode.
> 
> When interface is created, it updates regd rules accordingly.

Again what is "it"?

I'm having trouble discerning what is existing behavior and what is new 
behavior.

That distinction should be clear.  In the past the following template 
has been suggested:
   " Current code does (A), this has a problem when (B).
     We can improve this doing (C), because (D)."
<http://www.spinics.net/lists/kernel/msg1633438.html>

Obviously that exact format isn't required, but you should at least 
describe, if it isn't obvious:
1) what does the current code do
2) what is wrong with that code
3) what should be done to the code to fix the issue

I don't actually have an code patch comments