Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1064580rdb; Tue, 19 Sep 2023 20:41:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHERNMH97k5iTapWcWLMnT1qmtkdfrrMETq+q6qP6f8MAb3iyyUFW5V1nLFHnVT6OhhDVw X-Received: by 2002:a05:6a21:338d:b0:134:a478:5e4a with SMTP id yy13-20020a056a21338d00b00134a4785e4amr1752387pzb.17.1695181295504; Tue, 19 Sep 2023 20:41:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695181295; cv=none; d=google.com; s=arc-20160816; b=w0ovG9T9FC1DeUILcDFK7B7lJ9G0V4teww3peHznhydLWX/FllDCkxH5PeI3uFJkai jONZPxF+63PFQgF92Pmc8jgT19e7WbScGpbVPP8iwYmJZXmrfI+wADN3J6U2UGET6KWr RPwh0pfNi3qvsyQVQN0bfXMd7Cnbu9g8NcPzq34/6ghQ+sUEix801s6u1hUUUjwLC7IR mybxXqqYOGLwNO81FIrL89+5s62E8xhvLnINmnzWxmUZECxFvvDKwm9qxAicBRf8aYFn lYJ6+l4OhhfRYoUMH5bRY6J/pHTyXrSa6lWyyuMy8X9PJAgvXEkTSOMLqD4m+WQWF90G nu2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=pqBO68ZWgz7taZvIb6WDcGDVtStY5mtBA4ootGLbC3o=; fh=ciWSO4gAQ5eirAvdhkY/Um2P4Ao+HbKucMAmTNQiL8I=; b=e2WSbdd9dDKFwbhsIqqabsfYfkGKQxkMcoQcdOizEMgS1Vt63kMEaecMZsfJgx1v6s 1AaLTPK0N27RKkfC17FgPCVztlwOCJiXGv026A1kA13MNlRLeukSSs/nKuDYt8a0gTl5 ILRMkIaINx0ezNYfFG9t7OaejezxABUH3MZOKbqz2FJxhYgtTjHwyXCesfzrI8oHMD1X sVd7jASZNwneu9ACelEoh2dnuHhv2yqcohXrEkYoVYsusMmAjVJ0lWi0kBIPRiefAvpy luwyVyzyTj4HELqAtlqhjAwrDZEiocPvARwcDsP5BdX+g52fLPWUbDOO6QbPHGsO7qo2 wo1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQwaD1cf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u15-20020a170902714f00b001bf1d1d99f6si10723936plm.358.2023.09.19.20.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 20:41:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQwaD1cf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id ED2B1807791A; Tue, 19 Sep 2023 20:36:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbjITDgk (ORCPT + 56 others); Tue, 19 Sep 2023 23:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbjITDgj (ORCPT ); Tue, 19 Sep 2023 23:36:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72809F for ; Tue, 19 Sep 2023 20:36:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84630C433C8; Wed, 20 Sep 2023 03:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695180993; bh=EdUVZ07sJwQ3a76LpnnAsRSzwpDUz+5zvHA1l9TrDtA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WQwaD1cfMWV6surSFZD5E/+T6LvdSt1M7HmXKZZt5hOQJkR+ZNgmgGVjIENhQ0Sjs 4SSEQpB1di08mfna0LzRZV4994VQKduR57XwMqVW2N088yJlaYicTf1TCsktMMCfuc tNZ36yrQAQiOtFPBIT9R01eV8IWzn7MZds7kT1Ov2qIAIi+xPNSLXmlQ/nk/UWIF2s 2p4W+LrKSLZNiL0Crcw+Gg4Byi3OR/iSdKoP/77LhL615t0//i/fBv1qV61ruM+GAf KgpkY/FSiQ+NWNWAYMjEiL1bFrXw47uRfx7fRjR73Z1KTNQO4PhC93WE8/ADDKzTza luT1rDNMTkXuA== From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Shiji Yang Subject: Re: [PATCH wireless] wifi: mt76: mt76x02: fix MT76x0 external LNA gain handling References: <20230919194747.31647-1-nbd@nbd.name> Date: Wed, 20 Sep 2023 06:38:22 +0300 In-Reply-To: <20230919194747.31647-1-nbd@nbd.name> (Felix Fietkau's message of "Tue, 19 Sep 2023 21:47:47 +0200") Message-ID: <87zg1hjyz5.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 19 Sep 2023 20:36:47 -0700 (PDT) Felix Fietkau writes: > On MT76x0, LNA gain should be applied for both external and internal LNA. > On MT76x2, LNA gain should be treated as 0 for external LNA. > Move the LNA type based logic to mt76x2 in order to fix mt76x0. > > Fixes: 2daa67588f34 ("mt76x0: unify lna_gain parsing") > Reported-by: Shiji Yang > Signed-off-by: Felix Fietkau I assigned this to me on patchwork. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches