Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1265593rdb; Wed, 20 Sep 2023 04:42:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGALvJJvKJv8bptvG7ANoUjtNpbvbWmfx8RgwWyBtvm7Egszlj/3b/eszA/kTmJ7jFHtUPa X-Received: by 2002:a05:6a21:32a1:b0:158:1ade:8661 with SMTP id yt33-20020a056a2132a100b001581ade8661mr2823564pzb.18.1695210127122; Wed, 20 Sep 2023 04:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695210127; cv=none; d=google.com; s=arc-20160816; b=IjFJoTLYMLdDbQ1TqV0OPRfmyURIi1gGSvWpzu5rr2uc1klUKQCKnf3orcyP1eqLDx RRf5s6zXmNiiilBCNjpmWXxSjNAAiK55TRTJlwmUroIJ2M79jX4roRuEjv5CwRok6cXs 8Y7eeZbk5vTlnS4dSDiSlqf3zK4TJsWZh/FE5FtK0PJT9FRBDRQY3ejneze3GN3x1DTM HqMNPM4OCnIZmkXMmidCauOueLI+n523Sm8TFfA0uG1M6Fo3KJoqxpLxAV6rPN3VF1wI AQhODQTqHPDg6QfJyJAs48F2E7IApHrocp2FKERTQF7DTYycIWhMesQ8KTFxSz/lHgvN R6sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=kSsk02o1HyYQFlYKRCEXUx6AvKv6lJY+gZTQ8MOc91U=; fh=dWarYuQTmOBl1GZu4ZHDm0xHnCAzahTvesyqKS4M82g=; b=b5BA5XnAaOPQ4L9RtBkSbCFih5gx//526ylKiPMRxvQlljIZ4dSZiq34zs6NLPuFi/ BGQNb1Xfl6yR2MPRF0IK87sah+3Ypta42qacD4BT5fnN4UWw0zkq+nAlbZgi0QByaxDP icReXL9eRI3UTAoeFb83MY/FXqTXeiudU9RLOTTy0oy3HrQb4Wa4r3zLBF6xJG/VM6kA VEwVaxR5DX/Vzu4JKHKEb5TeuuZd1afR3+ooA1j2Lrabm6AKUlEGhw3KDkhg51MtjZ+0 4Tvy6VGo6hUZZg5sKM5SCp3tPiU/bQUuTQW4ZUTJ9kddSqy9t8aUMtvYZQikSQVfgo/H ig5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uw+1Wiaj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id b19-20020a630c13000000b00565e56713c7si11776755pgl.91.2023.09.20.04.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 04:42:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uw+1Wiaj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 38D5180B8DE4; Wed, 20 Sep 2023 04:16:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234437AbjITLQe (ORCPT + 56 others); Wed, 20 Sep 2023 07:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234431AbjITLQd (ORCPT ); Wed, 20 Sep 2023 07:16:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F752C9 for ; Wed, 20 Sep 2023 04:16:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55F84C433C8; Wed, 20 Sep 2023 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695208587; bh=swL+k+GVh0Gmc144V31CDhUbwzkBhnwhy9eGhMUPeL0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=uw+1Wiajs6JKJeP9yqX7v7feqTvtYqpnhfBD5h6xu4lBEQ2B1Pg1T+waTmyt27DEn nV8mO3Oib84t4asNvgdF2vovcP+Swn3CoU3YcIe4UpE96Dq3VYKFtb9MHDnj2b8r0f jFBgP/n/bRHECsP62JC6aZXRZdfTfCYRRXN2OqhdoELIIgt33hTHhE7i/oJNbtMiuF rcdA5lGZWw0Vl4D3YtmH27g44iwR70nVxtKmr5XLFQF3s0Xt7Gznusx9eugLPvzq8R pt/OaCt+QtZceijltP/RHPTM488zuaLn3BUwBNaoicZ24qxi6r3TpLACB/nMMAyYnl eKlrzcZkoWNDw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: rtw88: debug: Fix the NULL vs IS_ERR() bug for debugfs_create_file() From: Kalle Valo In-Reply-To: <20230919050651.962694-1-ruanjinjie@huawei.com> References: <20230919050651.962694-1-ruanjinjie@huawei.com> To: Jinjie Ruan Cc: , Ping-Ke Shih , Stanislaw Gruszka , Brian Norris , Yan-Hsuan Chuang , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169520858429.991705.11262505938866457143.kvalo@kernel.org> Date: Wed, 20 Sep 2023 11:16:26 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 04:16:31 -0700 (PDT) Jinjie Ruan wrote: > Since debugfs_create_file() return ERR_PTR and never return NULL, so use > IS_ERR() to check it instead of checking NULL. > > Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") > Signed-off-by: Jinjie Ruan > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 74f7957c9b1b wifi: rtw88: debug: Fix the NULL vs IS_ERR() bug for debugfs_create_file() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230919050651.962694-1-ruanjinjie@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches