Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <4a02dd43-c629-4c7c-83fe-256e6d444d60@locusrobotics.com>
Date:   Wed, 20 Sep 2023 11:27:02 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise
Content-Language: en-US
To:     ath10k@lists.infradead.org
References: <cover.1612915444.git.skhan@linuxfoundation.org>
 <76a816d983e6c4d636311738396f97971b5523fb.1612915444.git.skhan@linuxfoundation.org>
 <5c31f6dadbcc3dcb19239ad2b6106773@codeaurora.org>
 <87h7mktjgi.fsf@codeaurora.org>
 <db4cd172-6121-a0b7-6c3f-f95baae1c1ed@linuxfoundation.org>
 <87wnvesv8t.fsf@codeaurora.org>
 <82e3e0a2-d95b-cffb-4fa7-2eaa4513dd48@linuxfoundation.org>
Cc:     linux-wireless@vger.kernel.org, skhan@linuxfoundation.org,
        wgong@codeaurora.org, kvalo@codeaurora.org
From:   James Prestwood <jprestwood@locusrobotics.com>
In-Reply-To: <82e3e0a2-d95b-cffb-4fa7-2eaa4513dd48@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDhtWmlIR3VHckxUajVmcDRISXhIR3NsdWV5cmw3MlV0Y3pERDNxS0NMM1dr?=
 =?utf-8?B?TFREQnJJaVN6MjFldTRyTHg2c0trYUxWaGlnR0VnNWw4YzBaSm5iTkRWUVZ3?=
 =?utf-8?B?bkQrNzF3NGtiT1pVMkYwOEdiTEVEalhsdUlBc09pODJXQzVHcHVCY3E2T0FQ?=
 =?utf-8?B?MlZLbndFd3A4TTlGT0Vzbisyb1VjbHRuM045NVVZTGNFNkw1YStDYkdYMHNj?=
 =?utf-8?B?OW5JWG9lOTAvVFgvQ3p3UTFwQzRxMHppU3FUV2xCRXlrMTcrVWNBb0dkODRy?=
 =?utf-8?B?RkkrSzJKbEZ3VmtWOXZ5V244Z1h2Yy8zTVNYMjRkNG4va2pocElsSG0ySlVy?=
 =?utf-8?B?Y2RSSXBwdEZCZGJ6aEVwQ3FOVU8xSElwbFRYT2hmVzU1N24yS3hCVklFWjBj?=
 =?utf-8?B?aHp2TldmUzJLNGN3bUpMcHVIV0dwZmJ5RktWTklMaHp3QWdtb0VrT1N3TmRE?=
 =?utf-8?B?QVB6OGZML3ZEUWsybHFGZmtqN0lua25yYU9pSGpjbmQ0V25tWVFOaEhWbW9S?=
 =?utf-8?B?VVJTUllEcFA3RVRZRG4vQU1kUUIwOHhCcTMvYnljRjBwdU5EYTZxeExFcEpH?=
 =?utf-8?B?VlgvTmdQOWYweU9SZGFNNEg2VkpER3ZSRmNvWDBkTENZallGNjNrbnFPMDli?=
 =?utf-8?B?KzV0WmVVWDU1WklsV25Yb2NQbEU4SjFxdEVJa1g3aGJ5Umpya1B4aURZdTdh?=
 =?utf-8?B?MnltcEI4TXdpRGpxTjdDZWwxUlBaSGppUDN6bjZHaWc5TUhOaFRMZGVqdi9L?=
 =?utf-8?B?aWJuTUZERDFGdThSZk9vYXA5V0NjZnA3U2lweUhrTHFOK1dvUnR2MWIxUmFu?=
 =?utf-8?B?ekVwSGRTLzhRalpTeWMwSmJCREEvNXAwVURSZC9GekkvWlRwbzFVQnFsT3lU?=
 =?utf-8?B?Q2orWEloLzZMSlJFNWVjWnZQV25iZ1BscWtYbzAzRVVjcFdCMUJ2Q0NqN1ZY?=
 =?utf-8?B?SEdWWjJTb091SkRDQUdjejNhRWlBMTNKdlB3d2V2Z1htUlhFdmc1RkZiY2E1?=
 =?utf-8?B?bDdibnJwTjRJNlIzMyswczZDcE90VVd3Q3YwWVN2czNpUjFWQitHNlVQYS9h?=
 =?utf-8?B?em81dDhGL1RrUk9PSkZCNjE1LzFocHhEc2JNTjEwbFI4T1g3V3U3UEhCS09G?=
 =?utf-8?B?OXBxVmhiVktuK1pDSElVWGxyVEJyY1gxTXRRcHc1d1RNVklLbUM1cllyVmtK?=
 =?utf-8?B?c0Z1VGVSKy9ac1FBdEdGU2pFYlZJYm50N1ZRalpQaWNsUTBuYWk2cU9lclFi?=
 =?utf-8?B?dlRCeUo5N0k5SGkyNzdmdktVcms2NTNjdTBTeWVjdXh6Q3d4aDdvQ1lLYWJx?=
 =?utf-8?B?MTY4ZDR0T3FxRytnVHIxdzdDNEI4cnlnNDlsSE03WXptS2YvaVhiMjg4YTdR?=
 =?utf-8?B?UExpcWp4azUxeFFiMW4wVWt0SDFnRERPbVBSNDJLYU0rMXp4U2lycFNJM1Nm?=
 =?utf-8?B?RzVyc2t3UHdsYVc2QytTUnJLN0JyMEJQcWJ5cnI2eElMRUhnczRiQTBQYWtu?=
 =?utf-8?B?WklEa2RzNWM1eWpaTGVHSEZkVFo0SjlnWXNKN2hjUGh1NEwxVmNoN2xVcnVG?=
 =?utf-8?B?SGIydmlxZFlwVFJQdEIwUVVrVm8wZi9QTDhqdDhzd0haL1RwdHBFZW9NUjQ1?=
 =?utf-8?B?ZmVsTmNucnVOc0s5Z1h2OTF6TzZaY1JtRlN1MG9EQWhZa1N3c0lPZTFEbzhJ?=
 =?utf-8?B?TXYxYityL2djZzhDT2xGUk9mUStBMk0yUWVxS2daU1ppRER0WFNIWUFMdklJ?=
 =?utf-8?B?aDNVdE0wVFRkSFIvRFZBN2JKZm5YUWt2dklwbVFxTktMZkVzV3Y4T01Fd1FD?=
 =?utf-8?B?cmFkQnBIK29QaGlCYXFDaXlBM2k1MjNLaUI4V0N6T3M3M3VQSEJYaVB4alV1?=
 =?utf-8?B?TkNkT2RGVFVUTVNnbHBuQjVDd3FZSGlGRTRTYmxUd2RtZTNJMnVEQU9jbHhU?=
 =?utf-8?B?dGRLU3RSZm5oalhrN1J6MUNIUzRCN2lINWhTZ0hWamxXR1hJVUIwL2pCSHM3?=
 =?utf-8?B?c3Y0RkJqMFl3QVhJclFFMHk5YVBkZFk2RTdVTHM5eDMrQ0trRndhWlpGbU5W?=
 =?utf-8?B?aExmSFZzWWVxVGtucFhlcTlUVWJXNWl4b1lTWG05NTRCeW1QaTY5Yi9COGI5?=
 =?utf-8?B?bDdtNStMbUN1bUluOEtuZjhMVUovaDc3OXVzOHVrZmNuc3lyWXJCOGU2NGpE?=
 =?utf-8?B?L0E9PQ==?=
X-OriginatorOrg: locusrobotics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91480537-1c1d-4aac-3feb-08dbba0731d2
X-MS-Exchange-CrossTenant-AuthSource: BL3PR10MB6163.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 18:27:06.7793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 068f275f-67fa-4977-a33b-80fe854a9590
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lvN/rRM2VbLSxBK9YgqgKxPIQXTi+s1sItzJlJqOrtkbHa00V9EDTrfuMK2Eh+6Rsqj4qWWeCMANRDr6BgiqpjzVNg4gsNlUZDTlGwCA2Rk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7867
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 20 Sep 2023 11:27:27 -0700 (PDT)

On 2/26/21 10:01 AM, Shuah Khan wrote:
> On 2/11/21 4:24 AM, Kalle Valo wrote:
>> Shuah Khan <skhan@linuxfoundation.org> writes:
>>
>>> On 2/10/21 1:28 AM, Kalle Valo wrote:
>>>> Wen Gong <wgong@codeaurora.org> writes:
>>>>
>>>>> On 2021-02-10 08:42, Shuah Khan wrote:
>>>>>> ath10k_mac_get_rate_flags_ht() floods dmesg with the following
>>>>>> messages,
>>>>>> when it fails to find a match for mcs=7 and rate=1440.
>>>>>>
>>>>>> supported_ht_mcs_rate_nss2:
>>>>>> {7,  {1300, 2700, 1444, 3000} }
>>>>>>
>>>>>> ath10k_pci 0000:02:00.0: invalid ht params rate 1440 100kbps nss 2
>>>>>> mcs 7
>>>>>>
>>>>>> dev_warn_ratelimited() isn't helping the noise. Use dev_warn_once()
>>>>>> instead.
>>>>>>
>>>>>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>>>>>> ---
>>>>>>    drivers/net/wireless/ath/ath10k/mac.c | 5 +++--
>>>>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>>>>>> b/drivers/net/wireless/ath/ath10k/mac.c
>>>>>> index 3545ce7dce0a..276321f0cfdd 100644
>>>>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>>>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>>>>> @@ -8970,8 +8970,9 @@ static void 
>>>>>> ath10k_mac_get_rate_flags_ht(struct
>>>>>> ath10k *ar, u32 rate, u8 nss, u8
>>>>>>            *bw |= RATE_INFO_BW_40;
>>>>>>            *flags |= RATE_INFO_FLAGS_SHORT_GI;
>>>>>>        } else {
>>>>>> -        ath10k_warn(ar, "invalid ht params rate %d 100kbps nss 
>>>>>> %d mcs %d",
>>>>>> -                rate, nss, mcs);
>>>>>> +        dev_warn_once(ar->dev,
>>>>>> +                  "invalid ht params rate %d 100kbps nss %d mcs 
>>>>>> %d",
>>>>>> +                  rate, nss, mcs);
>>>>>>        }
>>>>>>    }
>>>>>
>>>>> The {7,  {1300, 2700, 1444, 3000} } is a correct value.
>>>>> The 1440 is report from firmware, its a wrong value, it has fixed in
>>>>> firmware.
>>>>
>>>> In what version?
>>>>
>>>
>>> Here is the info:
>>>
>>> ath10k_pci 0000:02:00.0: qca6174 hw3.2 target 0x05030000 chip_id
>>> 0x00340aff sub 17aa:0827
>>>
>>> ath10k_pci 0000:02:00.0: firmware ver WLAN.RM.4.4.1-00140-QCARMSWPZ-1
>>> api 6 features wowlan,ignore-otp,mfp crc32 29eb8ca1
>>>
>>> ath10k_pci 0000:02:00.0: board_file api 2 bmi_id N/A crc32 4ac0889b
>>>
>>> ath10k_pci 0000:02:00.0: htt-ver 3.60 wmi-op 4 htt-op 3 cal otp
>>> max-sta 32 raw 0 hwcrypto 1
>>>
>>>>> If change it to dev_warn_once, then it will have no chance to find 
>>>>> the
>>>>> other wrong values which report by firmware, and it indicate
>>>>> a wrong value to mac80211/cfg80211 and lead "iw wlan0 station dump"
>>>>> get a wrong bitrate.
>>>>
>>>
>>> Agreed.
>>>
>>>> I agree, we should keep this warning. If the firmware still keeps
>>>> sending invalid rates we should add a specific check to ignore the 
>>>> known
>>>> invalid values, but not all of them.
>>>>
>>>
>>> Would it be helpful to adjust the default rate limits and set the to
>>> a higher value instead. It might be difficult to account all possible
>>> invalid values?
>>>
>>> Something like, ath10k_warn_ratelimited() to adjust the
>>>
>>> DEFAULT_RATELIMIT_INTERVAL and DEFAULT_RATELIMIT_BURST using
>>> DEFINE_RATELIMIT_STATE
>>>
>>> Let me know if you like this idea. I can send a patch in to do this.
>>> I will hang on to this firmware version for a little but longer, so
>>> we have a test case. :)
>>
>> I would rather first try to fix the root cause, which is the firmware
>> sending invalid rates. Wen, you mentioned there's a fix in firmware. Do
>> you know which firmware version (and branch) has the fix?
>>
>
> Picking this back up. Wen, which firmware version has this fix? I can
> test this on my system and get rid of the noisy messages. :)
>
> thanks,
> -- Shuah

I know its been years, but reading through this Wen mentioned there is a 
fix in the firmware? I haven't tried all of the firmware binaries in 
Kalle's tree but the most recent definitely still spam the logs with 
this message. Is there a specific version I can use to get rid of these?

One thing to note is the older "firmware-4.bin" did not have this 
problem, but was met with worse problems like driver/firmware crashes.

Thanks,

James

>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>