Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1664516rdb; Wed, 20 Sep 2023 16:17:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0kKpjusLJYQQ6Qmi+UP+VF1aTJ+KPFsMV628XgDOoXyQTpauCn/syXSmaEFHtv9uTjRuo X-Received: by 2002:a17:902:c94f:b0:1c3:ea2a:9058 with SMTP id i15-20020a170902c94f00b001c3ea2a9058mr4210765pla.65.1695251867043; Wed, 20 Sep 2023 16:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695251867; cv=none; d=google.com; s=arc-20160816; b=tz3znFusFFy1KxjKK5UG4yYXkcW0cFyQZUH4XRjkXRV0az6i2fl0OXtBSAyo2F1aUQ c0YneViauni7Y3a9YJFXov369CI7UyI2cbjCAJEa4CcLtPk0jEhSrnZaNVWFlphmEiXh 8o0x9sr4NR0f7y1dHUvQPYFsDnfveK9Hnmd70aGpemmkh2PfJ6EoZb8Nju6SjJ9i79aY pxoI9pMO48Mi4qmElvyudYYqSvYACrlhb7p00seIK696xb10VAZuEfRwUY2ezGJDSlZp LRq65fMeitJlDqnNWE7FPaa3R+zZcJcNGcZ37AEy7l8b3KnFJusHgzRerc8QNHct7/nq O3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GGwpZPVEORkxfW1VbT3l7BERzQg7QGbMxJQ8TdJTA+4=; fh=aaZKW+6d1dfICLWPHMqyLoFtKv3A4TD9Kdt+8gJZZ+o=; b=kB5jKfqBkfMTFm+S5PYLvA7Rb0CJ8gxNB4eosGjps663ED+kKkOwI3UgJfVVW40n1Y jnNPMCjYI2+/JT6kMwJ5K5R60b+THq7PFcjzoNmpI9bZkiKTXRtSxFlBG4Mvao2DE03W rocwqifi25Tt5Uu5gNm61NNAo0JDvPBeMVcs6jX0KmjLelzV5JrQ6vQ2os8S4xeor/nN 3mGbq1K9Qac77UCLbRW+dcHkQkHUE9fikvF1oBhW2qHPaG4laewnIYgwtpW93q94MWma DbAF2JnvSVieKrmWSGEingL6sLxK23esy834rkAvgV9nBPjv39CEHVcpPqDVM3fq2Rdg 7HjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AcWrhqJQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id j6-20020a170903024600b001c470c5906bsi133623plh.221.2023.09.20.16.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 16:17:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AcWrhqJQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3D51880DBA72; Wed, 20 Sep 2023 16:08:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229497AbjITXH7 (ORCPT + 56 others); Wed, 20 Sep 2023 19:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjITXH7 (ORCPT ); Wed, 20 Sep 2023 19:07:59 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81677A3 for ; Wed, 20 Sep 2023 16:07:53 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1d6b5292aebso193194fac.1 for ; Wed, 20 Sep 2023 16:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695251272; x=1695856072; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GGwpZPVEORkxfW1VbT3l7BERzQg7QGbMxJQ8TdJTA+4=; b=AcWrhqJQ47NG3xJ3uRrti7+2vmjcakOlhxH6xBQlNGWhgmVxjplxO0z7kPOxCIChph a8vvoG63muPZS0RXtTveeB9kBbpWsRrwkR4WCZjsmek0bNHXtPXL+5CY/G8HjQ+6Of+F mpaHBythwbocXczY1zJv6RCT7b1zQkkzpilZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695251272; x=1695856072; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GGwpZPVEORkxfW1VbT3l7BERzQg7QGbMxJQ8TdJTA+4=; b=BCC+Hqn9pc4rH/qyOCLruDWCCqWGO34jZkdmsR3H3/FxyWg73ka6dI1MmPIMr/+t3u SfdNr/pAGk8IH0s+hoHmK5xkvsjcAKodDNh1HA6JrYDDkZJRSqT5rJOY4zrp1WSV7FQL fgvA33Rnk7KJPSxG0ZFMVrx/TYJHSLKvKX1UyH2K/43xFcVuOQu1J3NUyQzZmzQVkdS+ eZTI0efmHFEhMBJBLfN0sJdRQ7cKDV8JL/vGIOk7pMGrS7COnx7fWcFmxUVC44Fnm4Mi tCgj/uaM13UmOk3VVYVEelH2Z8+783dsJwguDdbjSAMCYIXs53nxhwDoZRlbLQ5r54/+ +hbg== X-Gm-Message-State: AOJu0YyGMZ1wc2pEawbr5NBgTx60eyR7NIMTFlxW6HhLtnUvLZe/hJmb ujNg4zgeWHOSdxc/NEsdl2LAGFoYyBh0hrxTqNaCGw== X-Received: by 2002:a05:6871:49cc:b0:1dc:723d:b8d0 with SMTP id ty12-20020a05687149cc00b001dc723db8d0mr364311oab.27.1695251272340; Wed, 20 Sep 2023 16:07:52 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:23d5:c394:2c98:ffcf]) by smtp.gmail.com with UTF8SMTPSA id d12-20020aa7814c000000b0066a2e8431a0sm57254pfn.183.2023.09.20.16.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 16:07:51 -0700 (PDT) Date: Wed, 20 Sep 2023 16:07:49 -0700 From: Brian Norris To: =?iso-8859-1?Q?V=EDctor?= Gonzalo Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata Message-ID: References: <20230914211938.28395-1-victor.gonzalo@anddroptable.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230914211938.28395-1-victor.gonzalo@anddroptable.net> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 20 Sep 2023 16:08:00 -0700 (PDT) On Fri, Sep 15, 2023 at 12:19:38AM +0300, V?ctor Gonzalo wrote: > The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to > add the firmware files needed to the module metadata. > > Signed-off-by: V?ctor Gonzalo > --- > drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++ > 1 file changed, 6 insertions(+) FWIW, when reviewing the other sub-drivers, I noticed sdio.c is missing an entry for SD8801_DEFAULT_FW_NAME. Mind sending a patch? For this: Acked-by: Brian Norris