Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Wed, 20 Sep 2023 16:31:38 -0700
From:   Brian Norris <briannorris@chromium.org>
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH 1/2] wifi: mwifiex: simplify PCIE write operations
Message-ID: <ZQuA2u9l1mCRVYdz@google.com>
References: <20230919132804.73340-1-dmantipov@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230919132804.73340-1-dmantipov@yandex.ru>
Precedence: bulk

On Tue, Sep 19, 2023 at 04:27:59PM +0300, Dmitry Antipov wrote:
> Since 'mwifiex_write_reg()' just issues void 'iowrite32()',
> convert the former to 'void' and simplify all related users
> (with the only exception of 'read_poll_timeout()' which
> explicitly requires a non-void function argument).
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 290 +++++---------------
>  1 file changed, 66 insertions(+), 224 deletions(-)

Acked-by: Brian Norris <briannorris@chromium.org>

> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index 6697132ecc97..88f632b9dd93 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
...  
> +/* Non-void wrapper needed for read_poll_timeout(). */
> +static inline int
> +mwifiex_write_reg_rpt(struct mwifiex_adapter *adapter, int reg, u32 data)

This is kind of a weird name, but I don't have better suggestions. Maybe
it helps dissuade people from using it outside its very specific context
(where you have to read the comment to understand what "rpt" means).