Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1716708rdb; Wed, 20 Sep 2023 18:33:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7IqlPGH7eSk6ZT77wliqcALsmlO4Yus8lYi77HPuTdA/dyAHb0dVsFr9J8uNJ+8OniSyT X-Received: by 2002:a05:6a00:4a03:b0:68a:4102:e483 with SMTP id do3-20020a056a004a0300b0068a4102e483mr8813532pfb.14.1695260012964; Wed, 20 Sep 2023 18:33:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695260012; cv=none; d=google.com; s=arc-20160816; b=OxC6aSAhPVqrnqsDxtpLMDAPr2WHgnXnUC3OCk+09kIFnJdQUXPexj6tJPX83jDPpA Y3lTO8EgAcmUvCuz9XDTykL03KbZoHMJadYrIGIkLLnLGKCDdmTq/Wy/R7P1jyxoDcSd G9pMFc1DDzRd69xa8uHSvkOgydwnbBa8MjmLB8WNCkhcG5UjuNC0LZcQIQdS7u5DS5H/ QKN2n3b+I60fPXf5X1xErFwY3ilEMn3Qu36dXdr3nJ/RpUJ4jG9eY1f4XCJ8wS+OcBU7 zd1ewr0UAInHs/T3nyPri5Vu84uYlGHwlV/JhQMv8HRUbrEpxoTTT6ojWyqP7bPLtqHq qlVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4O+a49wANz5JW2SXRQFiJWKtfetonYCX4XgQOEDgVJQ=; fh=xXsXjEvuhKvtuzwjmXROSmYlJK+2Lcg0UA3uf8C4nBs=; b=EfdL1cqkUrj4qrvffemgKg/8GIP64xMkOm7hvn/OPZBVeMSh6okcQ9uzRfWziAWo1A dfW4q+9PFRNDqiAWSPVjqQdMj0wJbrBqkGsjJD4jHo7q+l7EkjVk5BnPOQmJk2H8zhvG 4MJFYhWyF0DuqmJ1zstvdjJNGf3r/xSBDk03ktbvI8s1PKLLm9PSIGKRT8ehfjS5U7ZM hYNHGjQtL82svMiJi5vYlehQn/jTpCs+IQEJSKXhTGJoc0Mb33DghqmTfnjEaPZzB8K1 Eb4QBFHknlkSD076AXEYt/qcaSKXBF5wPiChj7SQqCIXeBAsCseU+83Cys9tJtRJ3Z3Q nt5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oRY58HaA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id az1-20020a056a02004100b00565aa20a07asi288984pgb.683.2023.09.20.18.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 18:33:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oRY58HaA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1EC2882E10BC; Wed, 20 Sep 2023 16:15:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjITXPJ (ORCPT + 56 others); Wed, 20 Sep 2023 19:15:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjITXPJ (ORCPT ); Wed, 20 Sep 2023 19:15:09 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EA4EC1 for ; Wed, 20 Sep 2023 16:15:03 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1bf1935f6c2so1860655ad.1 for ; Wed, 20 Sep 2023 16:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695251703; x=1695856503; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4O+a49wANz5JW2SXRQFiJWKtfetonYCX4XgQOEDgVJQ=; b=oRY58HaALlbgCY2B0InvxkpXVl/x+VuniykytOkt2v3Qskel0JglIYzJ5L7RK+1iOp k5U4ZO48be1VVlIJNFtb2CcWrWo8dhoj3TmeCOHGWlYceWNGMM2GagM3YYcrFHPs+Pnd tRp6oZRbD6j1qM8OUGonZ53oLaZFD7Nuumk24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695251703; x=1695856503; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4O+a49wANz5JW2SXRQFiJWKtfetonYCX4XgQOEDgVJQ=; b=nJs+0EdzeN4CgPQ+0kL/AlsNV7dy7gCE6sXYUsGnmlyq8KTEKMPBeGEMhJyj03Brne maYWPdcaBW2WkwZoAZS3lrLvKG73cUFvCUZLu/FoiWHIb6+1ET/wYodKw0kPubMHEwUb AWZGSfIWcyR3UuBnlLIZYaJ8iGbuMN4WDNGzhIWaeS66ABejvi5IPqiFKAKtro6tZ4pj 0p6m2cmNGLgJY553gAiDSa9wCFkPKQB6LjgCmxZEsCmhUf/PX4tu3huzpg8/ClfN15Ao 0OaekIqpUg1p9Pqy0Uei1ItO8hFJY+VnRO9zhjbBEPKY6K/r6+5ijJK4CkaZ3rnESvoR ao0w== X-Gm-Message-State: AOJu0YyxVtZu85AHLCeqB6ZpiDKYJixO+ouYHB+y3ZnbLwBVFyPHsfou S/2Vqhm4r28p6gmcCENS/1DImi3RHO2byPfOOZDrag== X-Received: by 2002:a17:902:e881:b0:1c4:314a:d045 with SMTP id w1-20020a170902e88100b001c4314ad045mr10127015plg.14.1695251702830; Wed, 20 Sep 2023 16:15:02 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:23d5:c394:2c98:ffcf]) by smtp.gmail.com with UTF8SMTPSA id z6-20020a1709027e8600b001c322a41188sm50796pla.117.2023.09.20.16.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 16:15:02 -0700 (PDT) Date: Wed, 20 Sep 2023 16:15:00 -0700 From: Brian Norris To: Dmitry Antipov Cc: Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait Message-ID: References: <20230920112259.18656-1-dmantipov@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920112259.18656-1-dmantipov@yandex.ru> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 20 Sep 2023 16:15:06 -0700 (PDT) On Wed, Sep 20, 2023 at 02:22:32PM +0300, Dmitry Antipov wrote: > In 'mwifiex_sdio_generic_fw_dump()', move (presumably placed > by mistake) 'if (tries == MAX_POLL_TRIES)' check to an outer > waiting loop. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov Have you tested this patch? You've certainly caught a logic bug, but that doesn't mean the seemingly obvious solution actually works. (Disclaimer: I haven't tested it.)