Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2233139rdb; Thu, 21 Sep 2023 12:17:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjTWWb4sPvRD0pEs7+8lVfyoLkVQKYpsit69Gwj6wHlf+tEP/hX81tzErMSwi3kHHStyqE X-Received: by 2002:a17:90b:4a8e:b0:263:9e9b:5586 with SMTP id lp14-20020a17090b4a8e00b002639e9b5586mr6221058pjb.44.1695323846491; Thu, 21 Sep 2023 12:17:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695323846; cv=none; d=google.com; s=arc-20160816; b=jiaGM2LHyNpk543rGCta3tR0FMPCs2EWlmBsTr3K0XzjRsrGO4n6UTokVUqCm+5bwk C7EPQLwGMujmCWn81l8avNRGoD5FqGie7h1R8bKIfTjWD1VBWoHveKtl/U8ehXF//4Vo bdNMtXUs3Z6bdRCKykcvTAU2zvzRthoQQvZbTa+TD08gyuHnQD+txdeW+iOrqhpCLwdW g71ofuxfO/eirQKK+3sim1HY5KEyM4NRmel381TUbWNqpj9pc2fo5GnPu7qs5/v5JV2A JvexvGEEUJVlQ8AyWP48x73I5XhT60c/XXy8jZRBuFfLNl/8RH25FrIUkqy5Emu+aIsL IePQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=AnV965b/fnPBWqtRbtUCOgxcI0jcVUq12o9SFD7XPA0=; fh=7zJXWzEnUlFFlbKm0OQcEQiQI4qncm66Kjcbjr7N8aI=; b=MZJi8KMft89yCcOLnxvlCpALEMujxCtv0jv3VxeffyCtxcuFKbdGMT4mMbHTYj26js 5TZYyP8Plt91tGUP3kCMvlKl9d9KqgMDh5VZCzrH5cW9U6kbfr24JNVYXEr9UchdyR7O i+dI/b1RNGsixf79kjQfq4eOySq0XeM5R2x3GeNulx1YtbTG+91ijeH3VbajGSlFmsXu HpenAwtlNuO1DZUYEguqlOsYPSlGwlgfOEqPWK5jQFaJvoDsmxzV5qcdDHjfH4RMgRPf wZs4BoPuzixBfzJJycsOeVg1eOcNOS2KIJi109RvO6hdycsFuiUtuX9aJixVn7Xq3Ad5 idMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q0AAb/hT"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id a21-20020a17090abe1500b0027198088485si4285980pjs.45.2023.09.21.12.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 12:17:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q0AAb/hT"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B1E2B8351579; Thu, 21 Sep 2023 12:02:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjIUTCV (ORCPT + 56 others); Thu, 21 Sep 2023 15:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjIUTCI (ORCPT ); Thu, 21 Sep 2023 15:02:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30C1E80FBE; Thu, 21 Sep 2023 10:36:58 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7765CC116B3; Thu, 21 Sep 2023 08:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695283446; bh=ikVEGvz/AoDXxl7OJz8v3M6JEuj84GWYAzbM3pSuSfs=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Q0AAb/hTsyZsWcttt+LH9287e9g6+ilMDd07ifknyZdtsttuFD/C7e8WN86RofEdm UVMgUWeJlRHX1OVx0DTpFzJzn/OV51Ppg+FiMaRtZ55XYp0MY90NMR/KifyziH12cN fY+4NSCJBY8omAlRFugv8mJ87l5UCi4RvZbpHJeyOcekfqgcDsGWuLI0hHWm4hpO3u ixqDd/UTnuHp1aDa0bDudiQM+yPoqEahXZhOI1AvRrVtWpm1NSqqQ90jomTQdCDwVS b1x+bH8jl7UBlk3Wxfu0SY+aur5ipB2vp+GmJgZGgehROHGImkqJ7iBSKcv+IT4mjc 81QyDj+54D/BA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume From: Kalle Valo In-Reply-To: <20230905013556.2595854-1-dzm91@hust.edu.cn> References: <20230905013556.2595854-1-dzm91@hust.edu.cn> To: Dongliang Mu Cc: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , hust-os-kernel-patches@googlegroups.com, Dongliang Mu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169528344376.1539628.7025381317587339647.kvalo@kernel.org> Date: Thu, 21 Sep 2023 08:04:05 +0000 (UTC) X-Spam-Status: No, score=-0.1 required=5.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:02:34 -0700 (PDT) Dongliang Mu wrote: > In ath9k_hif_usb_resume, the error handling code calls > ath9k_hif_usb_dealloc_urbs twice in different paths. > > To unify the error handling code, we move the else branch before > the if branch and drop one level of indentation of the if branch. > > In addition, move the ret variable at the end of variable declarations > to be reverse x-mas tree order. > > Note that this patch does not incur any functionability change. > > Signed-off-by: Dongliang Mu > Reviewed-by: Dan Carpenter > Acked-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. dc73b2059354 wifi: ath9k: clean up function ath9k_hif_usb_resume -- https://patchwork.kernel.org/project/linux-wireless/patch/20230905013556.2595854-1-dzm91@hust.edu.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches