Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2306774rdb; Thu, 21 Sep 2023 14:57:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/xFgHCAVUX6xHManzxARaqUXxuya0RYhoUbB8r+UVFUa0n7vzEX+8gMofbxGUUzd1ebhS X-Received: by 2002:a05:6a20:7483:b0:137:74f8:62ee with SMTP id p3-20020a056a20748300b0013774f862eemr7942666pzd.18.1695333433027; Thu, 21 Sep 2023 14:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695333433; cv=none; d=google.com; s=arc-20160816; b=DWPLG+xkxADTdOUrTcnl/8P0yr/Vutv/a+gqf0qXYhzO75LmiL5APJUfATbe7BN3lw VHmg4sqgx7KWWjfsiS3bViHfARaNfNwHUBce7F6YRz7xxc3bEWC3sfW1HCzamiSycpQd xWX3qDcEQvGh9UgWMI3ENaR9K5+j5i0n2imkiLzxGcjmSEJs+QZCLJrC2AqG8fdaEQzl lmla6JsUUKwnoTv4gKOk75EHd6KgtA9xk0lgzSNLgPandrpBmJ7FO/QvOGxAEXeWzo2v pBgOGPIc/nkERzvPBw55KW0RqaBcp0NW9AjBXCpSVB9FgCeRaZI7/qVZXjWfUGKzeBS3 OBNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=uXQJ0G3Fx/gO9vRym/5TU3O/LNv+7iUrGop34IsiMrU=; fh=dZq/eePXYQzwyv1RsCeW1yGA6H+QdBAZvMvRl/dxsEw=; b=IJNFnzKQTw4gz0eMZSFVvUXTqUMre5AksusQfYBNhaLAuLfkcpbiVD4z7bZbURaRCf +Ersff0cvbafxXWI6Bs5jyidaT8jv/SiQX5TG0Xtxb+IhWWdrGZX4bzdAQtLFDm9v7KB AtIEp9JD4Pmb6wyawB2FHHZnU82GDEM79a915JenYP3HE4Rc52cg18Z8jrxDhxabbq2+ UrWPs8KNo95wehoaveluTP02unpeszC46vfDOI82TKySEQhaLwCnOkb+1pHFUw0FsR9w tjoOHxGb8+gtX5IFej6FYfyeh0OcvXmMWuX+jK1V8LwDHXb0MYRoELd1V6UemeLV1l5I IvFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZQtzsaJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y18-20020a170902e19200b001b8ba81d04dsi2210801pla.395.2023.09.21.14.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 14:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZQtzsaJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id F2DB18313360; Thu, 21 Sep 2023 13:58:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232147AbjIUU56 (ORCPT + 56 others); Thu, 21 Sep 2023 16:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232250AbjIUU5g (ORCPT ); Thu, 21 Sep 2023 16:57:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4176C83F6A for ; Thu, 21 Sep 2023 10:37:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BF60C116B7; Thu, 21 Sep 2023 08:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695284101; bh=AHBLwwOIwVWEmEP99U0FHUEQNUBcOntQwAP8JLk0Nrw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oZQtzsaJoI5FcqsIFrLXfTKb3OPPmMerddAnyEue6eMDGmf74sMvx+jD/mt7bVlV8 lvWElRz1BmVrCaU4Cr1Nk5/4MI5rQDgZTKvgYEKQyEwr4wTqlFx+n6+/DaLXJjnRZH qvn0lBrmP/ZbfuoUlSCS8/oW3Ow7gIAxJy9/dL0/H+XdY1BINd+R5qe3+dfuPPHRgx PMVHXKD2NbpkoaVYlr7Yci5jZZU4Xvv/rnPBdVXISV/MdNw9pog6vOIJIC0bEXFt2D lELB5upUDb7e61eERDi67C3qs1NAvDZ66Z9wx6cDaICSs83rms7jqh2J3MqAXX4F7z L/buhWfrVQjqA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/5] wifi: ath11k: drop redundant check in ath11k_dp_rx_mon_dest_process() From: Kalle Valo In-Reply-To: <20230824075121.121144-1-dmantipov@yandex.ru> References: <20230824075121.121144-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Jeff Johnson , Tom Rix , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, ath11k@lists.infradead.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169528409870.1539628.16918837777689234702.kvalo@kernel.org> Date: Thu, 21 Sep 2023 08:15:00 +0000 (UTC) X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:58:05 -0700 (PDT) Dmitry Antipov wrote: > In 'ath11k_dp_rx_mon_dest_process()', 'mon_dst_srng' points to > a member of 'srng_list', which is a fixed-size array inside > 'struct ath11k_hal'. This way, if 'ring_id' is valid (i. e. > between 0 and HAL_SRNG_RING_ID_MAX - 1 inclusive), 'mon_dst_srng' > can't be NULL and so relevant check may be dropped. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 82ae3f463538 wifi: ath11k: drop redundant check in ath11k_dp_rx_mon_dest_process() 9066794113c4 wifi: ath11k: remove unused members of 'struct ath11k_base' -- https://patchwork.kernel.org/project/linux-wireless/patch/20230824075121.121144-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches