Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2351322rdb; Thu, 21 Sep 2023 16:36:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpvs8aoORRxx7wV6UjaT6+2sPSOmaDFR+BsE7RIMpPWcxdTwiCugV/5u4gI7M1dbma+jej X-Received: by 2002:a17:90a:8004:b0:274:a021:9383 with SMTP id b4-20020a17090a800400b00274a0219383mr6944149pjn.17.1695339410560; Thu, 21 Sep 2023 16:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695339410; cv=none; d=google.com; s=arc-20160816; b=GnV3mWEAKWD2fonQAT62KlZqsfoucvL0s3a3usuqw1rC8zTTypDteJKWnfm87rKaFe xJFyoWZdmOpZFCw8toiZqTdkHUuzZeOndvfdxgfD2pZT+Szx0nxMXZyy7EJz2Q7v9Cld zw1pbzApyAN1rAv4yvoNkSLcWaXTr7QlHA1hP0Fs0zLtvCctCv9AFkqvw8+3nQKfAKBs 0cfLHeZfWotD5BUHsORw9QhOL2QOdCuEul7PEE6cqMqv4ZNyKiqyhiGukhDuWTzIcKwo ewJMU6fFm2aQQQOPBt87R2/eMn1azx1KO3ipK2MAV8vtRA0dQmNNJT9wNbvSWQl35XQ7 3jgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :autocrypt:from:content-language:references:cc:to:user-agent :mime-version:date:message-id:dkim-signature; bh=+gEHwucdbnIDVVgdvxrJqZn2q9NFPe8RrwLL1a4fBj8=; fh=sCqLtAQx2BPAbcNfDmjMt8U1Yf+FF6DU8bNd+PTdixI=; b=YPDj6Gzehq49aj9xGhZLyHrs2tTxxCxYgLp6BcklsPA1mJV7Rrss/UH3sbWuFXNYJ/ kl3QGayiVzT9u0lupSDpJHxjXHI8MbhuWgzUM4GYIy6+M9noZS3saBrMxTcGV6Jzr9zr imQrkoM9VzxOqlivkX4Z0K8os+7QG4XoUzL2Ruc7QOshO0b5Ex/UkpnKCNpvHzbMAdOu B/TVGZ/fLYt87SHz6/tObH1Bv8VdcQS6tgjoY9l52Xnw2QtufaoaD7xBansiPMjJNoUD m1agrl0fqF28ngob+4quJtdYR0BjnOEEmcN/8Pt4fZuHoX4q4mWVxMQUtw0wiYmM7VJz F7Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=vZfZdhQG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id a17-20020a17090ad81100b00273edf4d3a5si4932567pjv.68.2023.09.21.16.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 16:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=vZfZdhQG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AD925804C498; Thu, 21 Sep 2023 15:30:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbjIUWac (ORCPT + 56 others); Thu, 21 Sep 2023 18:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232417AbjIUWaZ (ORCPT ); Thu, 21 Sep 2023 18:30:25 -0400 Received: from forward502c.mail.yandex.net (forward502c.mail.yandex.net [IPv6:2a02:6b8:c03:500:1:45:d181:d502]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6BA8768C for ; Thu, 21 Sep 2023 10:10:12 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-29.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-29.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:5586:0:640:b3c3:0]) by forward502c.mail.yandex.net (Yandex) with ESMTP id 54C0F5EA55; Thu, 21 Sep 2023 11:58:15 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-29.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id DwFAq3SDca60-J1zDWlCY; Thu, 21 Sep 2023 11:58:14 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1695286694; bh=+gEHwucdbnIDVVgdvxrJqZn2q9NFPe8RrwLL1a4fBj8=; h=In-Reply-To:Subject:To:From:Cc:Date:References:Message-ID; b=vZfZdhQGZkrpkERhC4uDM9m2y/E0buz0Xf85rcphGlGWQEUXiUY99BXtEmOBIfIvc 7i+SxUVyexu+YPd65a/IYFFXBMraPCOt964dcZ+thugLK/fYNoIq0WND++OUDLsWBN Vq4X/82o/oNvzDA/gZQ0jBWvEgXVtxB8WHz2huSc= Authentication-Results: mail-nwsmtp-smtp-production-main-29.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <75483209-4ac1-305f-83fb-9e9affc104fe@yandex.ru> Date: Thu, 21 Sep 2023 11:58:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Kalle Valo Cc: Jeff Johnson , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, ath10k@lists.infradead.org References: <997f4b09-7087-4788-aa2a-ef835ce6ebb3@quicinc.com> <20230824055117.42309-1-dmantipov@yandex.ru> <874jjpashn.fsf@kernel.org> Content-Language: en-US From: Dmitry Antipov Autocrypt: addr=dmantipov@yandex.ru; keydata= xsDNBGBYjL8BDAC1iFIjCNMSvYkyi04ln+5sTl5TCU9O5Ot/kaKKCstLq3TZ1zwsyeqF7S/q vBVSmkWHQaj80BlT/1m7BnFECMNV0M72+cTGfrX8edesMSzv/id+M+oe0adUeA07bBc2Rq2V YD88b1WgIkACQZVFCo+y7zXY64cZnf+NnI3jCPRfCKOFVwtj4OfkGZfcDAVAtxZCaksBpTHA tf24ay2PmV6q/QN+3IS9ZbHBs6maC1BQe6clFmpGMTvINJ032oN0Lm5ZkpNN+Xcp9393W34y v3aYT/OuT9eCbOxmjgMcXuERCMok72uqdhM8zkZlV85LRdW/Vy99u9gnu8Bm9UZrKTL94erm 0A9LSI/6BLa1Qzvgwkyd2h1r6f2MVmy71/csplvaDTAqlF/4iA4TS0icC0iXDyD+Oh3EfvgP iEc0OAnNps/SrDWUdZbJpLtxDrSl/jXEvFW7KkW5nfYoXzjfrdb89/m7o1HozGr1ArnsMhQC Uo/HlX4pPHWqEAFKJ5HEa/0AEQEAAc0kRG1pdHJ5IEFudGlwb3YgPGRtYW50aXBvdkB5YW5k ZXgucnU+wsEPBBMBCAA5FiEEgi6CDXNWvLfa6d7RtgcLSrzur7cFAmBYjL8FCQWjmoACGwMF CwkIBwIGFQgJCgsCBRYCAwEAAAoJELYHC0q87q+34CEMAKvYwHwegsKYeQokLHXeJVg/bcx9 gVBPj88G+hcI0+3VBdsEU0M521T4zKfS6i7FYWT+mLgf35wtj/kR4akAzU3VyucUqP92t0+T GTvzNiJXbb4a7uxpSvV/vExfPRG/iEKxzdnNiebSe2yS4UkxsVdwXRyH5uE0mqZbDX6Muzk8 O6h2jfzqfLSePNsxq+Sapa7CHiSQJkRiMXOHZJfXq6D+qpvnyh92hqBmrwDYZvNPmdVRIw3f mRFSKqSBq5J3pCKoEvAvJ6b0oyoVEwq7PoPgslJXwiuBzYhpubvSwPkdYD32Jk9CzKEF9z26 dPSVA9l8YJ4o023lU3tTKhSOWaZy2xwE5rYHCnBs5sSshjTYNiXflYf8pjWPbQ5So0lqxfJg 0FlMx2S8cWC7IPjfipKGof7W1DlXl1fVPs6UwCvBGkjUoSgstSZd/OcB/qIcouTmz0Pcd/jD nIFNw/ImUziCdCPRd8RNAddH/Fmx8R2h/DwipNp1DGY251gIJQVO3c7AzQRgWIzAAQwAyZj1 4kk+OmXzTpV9tkUqDGDseykicFMrEE9JTdSO7fiEE4Al86IPhITKRCrjsBdQ5QnmYXcnr3/9 i2RFI0Q7Evp0gD242jAJYgnCMXQXvWdfC55HyppWazwybDiyufW/CV3gmiiiJtUj3d8r8q6l aXMOGky37sRlv1UvjGyjwOxY6hBpB2oXdbpssqFOAgEw66zL54pazMOQ6g1fWmvQhUh0TpKj JZRGF/sib/ifBFHA/RQfAlP/jCsgnX57EOP3ALNwQqdsd5Nm1vxPqDOtKgo7e0qx3sNyk05F FR+f9px6eDbjE3dYfsicZd+aUOpa35EuOPXS0MC4b8SnTB6OW+pmEu/wNzWJ0vvvxX8afgPg lUQELheY+/bH25DnwBnWdlp45DZlz/LdancQdiRuCU77hC4fnntk2aClJh7L9Mh4J3QpBp3d h+vHyESFdWo5idUSNmWoPwLSYQ/evKynzeODU/afzOrDnUBEyyyPTknDxvBQZLv0q3vT0Uiq caL7ABEBAAHCwPwEGAEIACYWIQSCLoINc1a8t9rp3tG2BwtKvO6vtwUCYFiMwAUJBaOagAIb DAAKCRC2BwtKvO6vtwe/C/40zBwVFhiQTVJ5v9heTiIwfE68ZIKVnr+tq6+/z/wrRGNro4PZ fnqumrZtC+nD2Aj5ktNmrwlL2gTauhMT/L0tUrr287D4AHnXfZJT9fra+1NozFm7OeYkcgxh EG2TElxcnXSanQffA7Xx25423FD0dkh2Z5omMqH7cvmh45hBAO/6o9VltTe9T5/6mAqUjIaY 05v2npSKsXqavaiLt4MDutgkhFCfE5PTHWEQAjnXNd0UQeBqR7/JWS55KtwsFcPvyHblW4be 9urNPdoikGY+vF+LtIbXBgwK0qp03ivp7Ye1NcoI4n4PkGusOCD4jrzwmD18o0b31JNd2JAB hETgYXDi/9rBHry1xGnjzuEBalpEiTAehORU2bOVje0FBQ8Pz1C/lhyVW/wrHlW7uNqNGuop Pj5JUAPxMu1UKx+0KQn6HYa0bfGqstmF+d6Stj3W5VAN5J9e80MHqxg8XuXirm/6dH/mm4xc tx98MCutXbJWn55RtnVKbpIiMfBrcB8= Subject: Re: [PATCH 1/6] [v3] wifi: ath10k: cleanup CE ring initialization In-Reply-To: <874jjpashn.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:30:49 -0700 (PDT) On 9/20/23 16:23, Kalle Valo wrote: > I have on purpose avoided to use void functions in ath10k/ath11k/ath12k. > The problem is that if some of the functions return void and some of the > functions return int it's much harder to review the code. I realize that you're constantly overloaded with reviewing a lot of patches... > If most/all of the functions return the same error value type as int > it makes a lot easier to read the code. ...but still not sure that this is reasonable for any non-trivial piece of the source code. OTOH if both you and Jeff are agreed on preserving existing ath1x style, I will definitely take this decision into account and try to redesign this series in attempt to fit the current design as much as possible. Dmitry