Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2388229rdb; Thu, 21 Sep 2023 18:11:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1gT86GMhtHd0YonFt5C+mm4a/PXkvj9bzX3A390mX3+jT1CUexKlxumpytty/tlciXZWh X-Received: by 2002:a17:90a:ac0e:b0:268:fc26:73a9 with SMTP id o14-20020a17090aac0e00b00268fc2673a9mr6509000pjq.40.1695345099429; Thu, 21 Sep 2023 18:11:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695345099; cv=none; d=google.com; s=arc-20160816; b=r92wfZ/OR0d0ZEg7ALSO1lU0KKmC6jRwjCsX878HkyzMUc4TJptOXvNsLR/ABdxc4Y fRKMbpJxTmuXUqhhron3z01W5hbU5AbCVRd55fNU/bFEs9RUbaqT1v3DEvlL6igODmE1 Rc5In2hHVqKEdXEi4kR4MBvysIJtiFUKxfp6cOhFId0qLKjew96BGVySudeqIgVcQNYB TaNTlZ/5SLP3GpKdPruQ78JhyVHdKRswr6k4pcUC6ByjQIAeO/kp6DlA9Etr7dRaLneR UuK8iw+N5ZglYQaEKRO6B11zDZdIxA6hU8KKEfVGJTmKwLB8TG/pQhnOi5ScJw009zvo rMng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dtZ8/QKJFMH+Yar7o+OrLtggPi7gjvft11ZU/v43g9g=; fh=Y2IfAqdjkYQAx7XZcGq/8JceY1atOOwfX771vvMvH7o=; b=ddhKjpxWUcIcveaS/2tEp9OFDbcJISaWJqpr1DynQ3o0IY3qsVdOaP4TjvLphc/vgO GHyEUj581vsyx3n0fDeYgC1juTS1jvq7a3Vr3HAHGTJvji5XHzzNm0OrlG80imnpVEvq sncos596TtrYs45bcxO6ofLP4fUnorY03yrP7jHRhZeBvCqd85AESiSd/h1rSdMLKEoV m5mSw24feJsij0U4WJNV3AShOPSzkfvhfQxge92wnhVMQ1AXMhWveKMKBzCUTUiLVNYA HHt3CWcF7L+IWqsNVoK8p3g0JLnLiBGi8BIT1WD+Jnx55ckoG6tOeJPRj4thbCuzHi6U xpmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mSkCKAQw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id rj2-20020a17090b3e8200b0024e4ace1a41si2983285pjb.183.2023.09.21.18.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 18:11:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mSkCKAQw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EE4BE8332343; Thu, 21 Sep 2023 12:50:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbjIUTuq (ORCPT + 56 others); Thu, 21 Sep 2023 15:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbjIUTug (ORCPT ); Thu, 21 Sep 2023 15:50:36 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E85B7697BA for ; Thu, 21 Sep 2023 10:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695318642; x=1726854642; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=byABH+hsUoi5S/yMfj0RVxmAy470GYhDMUlm2zglCGo=; b=mSkCKAQwPx5c9FdLMS2VQCXXJqOQ98iRsU65P6DIX0uMf/Zetv7XCqO1 wrsNP6M7OUX6ygBXpdxBIGDF8zbpaLMxdBcBhSJ1/mS6E2YG4ThPYSeKD Dyc+EGy6JRQOj4/YV0/SQfcb2Z88AvgQ3T63Jc13LHpJrlU0LiF0uEyNR Wxek2eR/mwppd0OZFxKP/gKCRCTdlHt4B1859gbHTprE3NdzYKewE11ne f0sLtZrLWbhjgplEn3qHXqaCW0cah6fbf/dC86hhAM4vzD19XhVxNxK55 gwnGVY505qqyS5FkPpKnFR7DD4RhVJ2h7I2J3a1RYWgJZ0YWxAONkuZiu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="384305474" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="384305474" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:59:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="740545656" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="740545656" Received: from rchuwer-mobl.ger.corp.intel.com (HELO ggreenma-mobl2.lan) ([10.214.229.163]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:59:06 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 11/12] wifi: iwlwifi: mvm: check for iwl_mvm_mld_update_sta() errors Date: Thu, 21 Sep 2023 11:58:09 +0300 Message-Id: <20230921110727.a9496c232d48.I74adaa8f3c6fd3252348e79f18605246936ef27d@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230921085810.693048-1-gregory.greenman@intel.com> References: <20230921085810.693048-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:50:48 -0700 (PDT) From: Johannes Berg The return value of this function is assigned, but then unused. Check for errors here. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index 4e9d19eb31f1..1464aad039e1 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -697,6 +697,8 @@ int iwl_mvm_mld_add_sta(struct iwl_mvm *mvm, struct ieee80211_vif *vif, /* at this stage sta link pointers are already allocated */ ret = iwl_mvm_mld_update_sta(mvm, vif, sta); + if (ret) + goto err; for_each_sta_active_link(vif, sta, link_sta, link_id) { struct ieee80211_bss_conf *link_conf = -- 2.38.1