Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2391133rdb; Thu, 21 Sep 2023 18:19:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0bh/2WFhHjnskSp3wzEaJKtuvhZN9dpdTKRUR3PK3i969W5pxeGT5eBgZVr8gl2jB1LmK X-Received: by 2002:a17:90b:1e0f:b0:26d:4312:17e5 with SMTP id pg15-20020a17090b1e0f00b0026d431217e5mr6780582pjb.6.1695345560401; Thu, 21 Sep 2023 18:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695345560; cv=none; d=google.com; s=arc-20160816; b=AO3RfWNYnlqGx3Seg/YJEZeDGxNlRXhtTWkMiAOQsgpXDBPVdYDdX4LNsiue1J0hk2 xOEQnj4dgjm+0sod9ia9B78SUIiXvu+orcf5Fbg6kKLoYxDW4cBLDuaAHUAUxnSAiwMT bgfEmw6sDMA/HMiVFq0r3m6E7T9luIs15Mzm3bDuEGG4YE1GoOWRxr80g/8FwUcfp8ay R2WRebIpP06ORH7OgECHBSO3VkFEW1WjEzZVZEN9ZlZQ4ZVSouZkbGBCCAZ8c96Q4opb vVu8Yiv+yX5IIbuAnnPMpUtHFrcXw/QccjSA+1V1i4GjTBCOSwxcdqnWz1xZwlBmcGjk Iq4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nFa5uWbN4ekEfnCXqRSQxeNtOb4wgR9IqU/XALfu8+k=; fh=Y2IfAqdjkYQAx7XZcGq/8JceY1atOOwfX771vvMvH7o=; b=ulIjCVsZTmjAQ3nB9z8TJ7UsK9h0WKnVg++3Q7Hfu1UppMkd7R5DbnYuVlIvX0OtYK YdqZQnfl8dBdzhR0E860j2ekaKBZHMpzaVQ+Ofen+1UU7RlVylhTwcrXO+NLvprKf59f 2QqpXlcAdZrlQoalOzZMwbolncfSLk7MF3+Em/4Afgj8uyDu37cusIC7e82Niz+fQlOQ 5B3lrw6rap4OcACMcxeExmrnPNsKi7Ow8RNWf8HsrLf7YQiqm62pO1kRowSGo5azVmq/ TR7ksXneDi9W6hfXCIp1BZOAKSAn4Fz7yMdXonaVfOeeFDKRckpQjUjmStZWx9uDqKAb 3T3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AwiKz1IV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id on7-20020a17090b1d0700b0025de453ee4csi3155312pjb.168.2023.09.21.18.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 18:19:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AwiKz1IV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id C940B809C404; Thu, 21 Sep 2023 12:05:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbjIUTEg (ORCPT + 56 others); Thu, 21 Sep 2023 15:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbjIUTEF (ORCPT ); Thu, 21 Sep 2023 15:04:05 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7241B900C for ; Thu, 21 Sep 2023 10:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695318633; x=1726854633; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3wYAlaqvKcESlmdTGDDKXMthjEYbZ/B/YJKPDqLykZA=; b=AwiKz1IVtlgFuFkNiSgSjv34uT5Z3cN+byYRd4X+Tm5+eHeAmgEIyfyn SlyqmMXIjJfkDyl8AlitwPM3hoLGjtujA843khEpmdAVROH+E/Ja89Koy y+fc8M41EmXRLosq5d7yaSAXGJ77uuDVB2+AqNMDEWlJkqMtBiMIzd3O7 XP7DgjVil0BHJrW4A3GzWTCDTdBrIFc9kFYoyCb9BudrVUwUlKPHSeRWP vRBxtK0rtdll7/rlvUtz26ehyEFt6TDGB8zU7XnUpFqB3l4bZKIGnWBiX IaXq0jp2oVqARJNabze3KVu/ay2tr+/CKanoflJjnE2++RelaQcEJrFH0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="384305384" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="384305384" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:59:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="740545590" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="740545590" Received: from rchuwer-mobl.ger.corp.intel.com (HELO ggreenma-mobl2.lan) ([10.214.229.163]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 01:59:00 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 08/12] wifi: iwlwifi: mvm: make pldr_sync AX210 specific Date: Thu, 21 Sep 2023 11:58:06 +0300 Message-Id: <20230921110726.928901700ad8.I648efdc4400d9e537359915a9a8f363d5d255ead@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230921085810.693048-1-gregory.greenman@intel.com> References: <20230921085810.693048-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:05:09 -0700 (PDT) From: Johannes Berg The register here is device specific, so we need to gate the reading/checking to apply only on AX210 family. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 6e5c0f81e041..5c719636c9bd 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -593,11 +593,13 @@ static int iwl_run_unified_mvm_ucode(struct iwl_mvm *mvm) mvm->rfkill_safe_init_done = false; - sb_cfg = iwl_read_umac_prph(mvm->trans, SB_MODIFY_CFG_FLAG); - /* if needed, we'll reset this on our way out later */ - mvm->pldr_sync = !(sb_cfg & SB_CFG_RESIDES_IN_OTP_MASK); - if (mvm->pldr_sync && iwl_mei_pldr_req()) - return -EBUSY; + if (mvm->trans->trans_cfg->device_family == IWL_DEVICE_FAMILY_AX210) { + sb_cfg = iwl_read_umac_prph(mvm->trans, SB_MODIFY_CFG_FLAG); + /* if needed, we'll reset this on our way out later */ + mvm->pldr_sync = !(sb_cfg & SB_CFG_RESIDES_IN_OTP_MASK); + if (mvm->pldr_sync && iwl_mei_pldr_req()) + return -EBUSY; + } iwl_init_notification_wait(&mvm->notif_wait, &init_wait, -- 2.38.1