Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <5e9439c5-fc02-4a18-8cc8-c76998bfcbc6@quicinc.com>
Date:   Fri, 22 Sep 2023 15:09:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 05/13] wifi: ath11k: update regulatory rules when
 connect to AP on 6 GHz band for station
Content-Language: en-US
To:     Wen Gong <quic_wgong@quicinc.com>, <ath11k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>, <kvalo@kernel.org>,
        <quic_jjohnson@quicinc.com>
References: <20230920082349.29111-1-quic_wgong@quicinc.com>
 <20230920082349.29111-6-quic_wgong@quicinc.com>
From:   Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <20230920082349.29111-6-quic_wgong@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/20/23 13:53, Wen Gong wrote:

> +	if (ath11k_mac_supports_6ghz_cc_ext(ar) &&
> +	    ctx->def.chan->band == NL80211_BAND_6GHZ &&
> +	    arvif->vdev_type == WMI_VDEV_TYPE_STA) {
> +		reg_info = &ab->reg_info_store[ar->pdev_idx];
> +		power_type = vif->bss_conf.power_type;
> +		ath11k_dbg(ab, ATH11K_DBG_MAC, "mac chanctx power type %d\n",
> +			   power_type);
> +		if (power_type == IEEE80211_REG_UNSET_AP)
> +			power_type = IEEE80211_REG_LPI_AP;
Why having _UNSET_ power type in vif->bss_conf.power_type is fine? 
Typically, during association, we would be setting this from the 
beacon/association response frame's HE 6 GHz Operation Info Field. So is 
it fine if the field is carrying some info which we don't know (or may 
be don't support it yet)? Why are we masking it with _LPI_ mode?

Also, I see that currently mac80211 only sets LPI or SP. So let's say 
STA is trying to connect to VLP AP, mac80211 will set it as _UNSET_. And 
then here, we will be treating it as LPI AP. Is that fine?