Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp211162rdh; Sat, 23 Sep 2023 07:26:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNweZwt6ulkS74aEcd4SoE5QXzfJzSJU97pqQPimhREaMKizHuTUrZ0iN+VPMX36rTbG5l X-Received: by 2002:a05:6358:7250:b0:125:a552:4389 with SMTP id i16-20020a056358725000b00125a5524389mr2805424rwa.22.1695479161746; Sat, 23 Sep 2023 07:26:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695479161; cv=none; d=google.com; s=arc-20160816; b=sdHQvNZWdU2e82YZ5SIN47SAQ2F+E/JWBKNfrPkcm8HzNyMuLBcaSDFAjKmbwW804u tyKEETAV5ksjybQHvQgVkv5Z2XnxCPuwBaE/q9sVkOIMyZlAUutkCWie2ZYtPXLfbFwp phIxqxbkrp5ReUcy5uS7vp9uVXjkr2qA8q5xavpFA+22Rop5kh2HoCq/Wg7EyS5pA2Id vBqw+4FyAH7wibc5uxNJEEIHdBgBWTvBAQkjdWn57+LHJL9jxjiHuzlO0K60PPA/Z2a3 qrEFvLEdrsmVrE6BAr8rhwLr939lIPnpjwIAKh3ulu3gzF8vXSgxDTv/lKUZtktqlWsS qC7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=1iLEqFnILMt+wkr8WBn84dfrLSx+1tgjaK7k9gA8Y7I=; fh=Ch1cBOWOJNgqKwWFCm4BOeQp/xna8hFjHlyrl2SL9KM=; b=UIum149s4ar4KZYvkgnTvhAlzDcpi0jTQGRP7xZ6e7AWCrYYeSVbyJNBH3mgEXOPTa EF8UV1NB58ql0VkICK0VT+qspo3+W3Rhl3FS9Lxib/HUw+nzzoOx7eQXSJMCVuAspu4Z oQIasnOx7mmNGhxa4IEq6fwwG4ONefh8DitjKdCvfXp0NvejuLv7CtEY/MhAos6IIkZ1 K86H7oVsBZiiTtUotOdt8LSSqoFRgt5Nh3XdFq4d+Y+x9r/JvJzat5bubjIBJjRePc2q sC1uZ+TVQ4Skkv8nxjJVLkcPMwZHShXCe0SNyTWYOsjCq1qOXfXvMIwD+StMZl/kAXOf zXaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=BvuyUfs0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id i198-20020a639dcf000000b00537c6c285a0si5860954pgd.167.2023.09.23.07.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 07:26:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=BvuyUfs0; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 054CE82B2048; Sat, 23 Sep 2023 07:14:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbjIWOOn (ORCPT + 56 others); Sat, 23 Sep 2023 10:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbjIWOOl (ORCPT ); Sat, 23 Sep 2023 10:14:41 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26CF9E for ; Sat, 23 Sep 2023 07:14:34 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d857847be8cso4091993276.0 for ; Sat, 23 Sep 2023 07:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1695478474; x=1696083274; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1iLEqFnILMt+wkr8WBn84dfrLSx+1tgjaK7k9gA8Y7I=; b=BvuyUfs0yaNFItagZaHU4BMTk/Xe9X4KaVASNEaSWD3RkmTBstzsJgSC4DnzcKkQJH wgmFeBnd6gjQ567A9Z7VepnpjKNfHeAMpHyx7GxaYyuQKgdtW6hE1ufOIHUv5sMyNps9 wOHu68ByPqb3wby4AbVBrLCoudEGrHKzGlZDo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695478474; x=1696083274; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1iLEqFnILMt+wkr8WBn84dfrLSx+1tgjaK7k9gA8Y7I=; b=O1g2qCgdBAv4c4Cw/D0wgRH/RH2ayW9q1H62wCVTKJTuquyEwwFUyg/jQiPr6CZ4Oa NIaFO1wafEYvy2+eQ+sRamog/UXEJuM5pbxkpJ/alItlD2dJez3lp8Red4YMYwSkUaPg 4UMj4NQcS/oQqxID1i0FYdocBm0X9jBTT50cUwbsDCiJPG0VV5D4nOO9hsACQN/NcOaY FW06sLIMDxBden7WGFXMBl9aT1YvMysG0i2xndC8ZVBWpKW6+IAjnyQqjpdnBZpkD80c BFJn5Fa2xf8LtxjKky0ZBmtiZNjGKf25g1Whq+VAFfKAmPcLfQypl4RkLm4PeL7H+Vc6 O2Ow== X-Gm-Message-State: AOJu0Yw/OBNSrtawSRKXrWXR9jSSN9+OjJhEkrJKg9kSwIfzBi0wyTMz TtxOOCtRYo+r1VZqkeXZLA2F9zM2XO+alB+T3qMwgUv0r9un0v4kn+c= X-Received: by 2002:a25:8244:0:b0:d81:9939:91a5 with SMTP id d4-20020a258244000000b00d81993991a5mr1765015ybn.39.1695478474012; Sat, 23 Sep 2023 07:14:34 -0700 (PDT) MIME-Version: 1.0 References: <05bfe2ff2771770ce119601adf30e14dded3a4ff.camel@sipsolutions.net> In-Reply-To: <05bfe2ff2771770ce119601adf30e14dded3a4ff.camel@sipsolutions.net> From: Vinayak Yadawad Date: Sat, 23 Sep 2023 19:44:24 +0530 Message-ID: Subject: Re: [PATCH 1/1] cfg80211: OWE DH IE handling offload To: Johannes Berg Cc: linux-wireless@vger.kernel.org, jithu.jance@broadcom.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000030aa63060607580c" X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 23 Sep 2023 07:14:39 -0700 (PDT) X-Spam-Level: ** --00000000000030aa63060607580c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Johannes, >Seems like you'd also need something that userspace actually says >"please offload this", so you don't end up doing it twice if it's an >older userspace? If its older user space, the connect context will prepare the DH IEs and pass it down to the driver and driver can use it without having to generate again- so no other indication is required from user space. With newer user space, the DH IEs won't come down. Regards, Vinayak On Fri, Sep 22, 2023 at 3:01=E2=80=AFPM Johannes Berg wrote: > > On Fri, 2023-09-22 at 14:55 +0530, Vinayak Yadawad wrote: > > Introduce new feature flags for OWE offload that driver can > > advertise to indicate kernel/application space to avoid DH IE > > handling. When this flag is advertised, the driver/device will > > take care of DH IE inclusion and processing of peer DH IE to > > generate PMK. > > > > Seems like you'd also need something that userspace actually says > "please offload this", so you don't end up doing it twice if it's an > older userspace? > > johannes --00000000000030aa63060607580c Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDEjF3ute0cvPjxoy1DANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxNDAxMTZaFw0yNTA5MTAxNDAxMTZaMIGU MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGDAWBgNVBAMTD1ZpbmF5YWsgWWFkYXdhZDErMCkGCSqGSIb3 DQEJARYcdmluYXlhay55YWRhd2FkQGJyb2FkY29tLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEP ADCCAQoCggEBALGluSWGaYhsVi4bVabRPDQnYm//51u0IMWWKXgroawPGc8DFXsY5rRTKSEe2t57 Hcu6+9qBRZbf5cEsMo7DsnKxIforzj/CyPiHEGEVZeYlY77I+PsanMKbsn/DPEm8SSUHQTolLSDs CLNrmVICkId5Y89k1xD0LqFL8po1wGwL+UK16vjVcp3V8IUpjtysuMxSc94V6stvWZav4sEyQ1bz RY30ttFfLGgUxOvRzd7UPGXmjiRyV20Vv+kGag5aTueKGHUv49TWypHgJc4PX8L9y3VouEhbWmGb bwuQjKELfovabHM5PWUVRda3t72kGFVMkIZ65u6DCdyjPFCUGnMCAwEAAaOCAd0wggHZMA4GA1Ud DwEB/wQEAwIFoDCBowYIKwYBBQUHAQEEgZYwgZMwTgYIKwYBBQUHMAKGQmh0dHA6Ly9zZWN1cmUu Z2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNydDBBBggr BgEFBQcwAYY1aHR0cDovL29jc3AuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJj YTIwMjAwTQYDVR0gBEYwRDBCBgorBgEEAaAyASgKMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3 Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAkGA1UdEwQCMAAwSQYDVR0fBEIwQDA+oDygOoY4 aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcmww JwYDVR0RBCAwHoEcdmluYXlhay55YWRhd2FkQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUS9fHYxc9qAJz gfBKun+P2LFASWAwDQYJKoZIhvcNAQELBQADggEBABiMQNJRdQCxXwqwqb49w0ZXCxsSrs3gS4NA G3H9oJuvzJ8ml5Z9l9p9PGPHcrmc/BdFjIIu/wQftGETAf1+W6AvxXqYmA2flaogebRueqCMQJiy xbJlOSry64AGOzHYULvI70tt9woEYgSx3I703b7c8o7eWCiU267y/WNzH+MpZ12h9q0Jwhw8uH9S BTl38q8FNdCLAiM1OD+blhu7LqMLVaAEEeoUGhRxdNkvMGss1Z7/ZefenAfm9IpiaGR0PQhBwI7c spqD/wIJUULcXiaj0eatDUjsrx3QN9OZOh3iubCt0uBoxCQUGuvxqd3Qz4FVKMSzEIzs8v/hwR+T nTkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgxIxd7r XtHLz48aMtQwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIDaovWPOhaFAnoxrRfIl BlGyvYcZJKNnLzJDp6TWH8xOMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDkyMzE0MTQzNFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBH2Q0zzTkks2/8ZGh8qg5hwhlZIeoL1mRhsikF WKw23bV4JvFROKHOIpkBxsogzwa2LMI6M0fH6JtFOJdwzhlrGzSW1MOA6VZqXcwkMAlcqzEuMLsI z1AZOe5U2xUytzNR59v8OKU2XisDcL7KvoHOKT4l0wIoFDha7VuOEZDTAWOIzci1YC+gCFflBAxZ OMXThejtq+CV2gLwqJ+TxKweRrNJZfCPgU5J63OMXriz6Fx8zUJZeMyWAjLPNYBYkiPe+/DVzTTF A9nW/FdeJUiurknyu7OhSRV4KSN7goIs9mANXIIKMa17DgUY+KLDhmWaYD4DCnfcc+alj1fSobRb --00000000000030aa63060607580c--