Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <7fd041470156c1e5da921d74c87fccac01aec4a7.camel@sipsolutions.net>
Subject: Re: [PATCH v8 0/5] Additional processing in beacon updates (v8)
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <quic_alokad@quicinc.com>,
        Jeff Johnson <quic_jjohnson@quicinc.com>,
        linux-wireless@vger.kernel.org
Date:   Mon, 25 Sep 2023 09:17:47 +0200
In-Reply-To: <53c81779-d423-c266-c8bd-f9583538c2e5@quicinc.com>
References: <20230727174100.11721-1-quic_alokad@quicinc.com>
         <46340c48-285e-4e2a-b6e9-802f922f0c2c@quicinc.com>
         <759fb125-7bfc-7d85-5c71-0a134030a9b9@quicinc.com>
         <6e680b33-55f5-2c49-3458-6baa4d8cff52@quicinc.com>
         <1912863dcd17aa50b09d1ddfc889478eb323f901.camel@sipsolutions.net>
         <53c81779-d423-c266-c8bd-f9583538c2e5@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-09-18 at 15:29 -0700, Aloka Dixit wrote:
> > Alternatively, maybe we should indeed change the prototype again and
> > introduce a new struct cfg80211_ap_update that contains only the
> > parameters that change?
> >=20
> > That feels a bit harder, but really it isn't by that much - in mac80211
> > ieee80211_set_fils_discovery() etc. already take the sub-parameters
> > (&params->fils_discovery), so not a problem there, and in nl80211 we
> > could as well pass struct cfg80211_fils_discovery directly to
> > nl80211_parse_fils_discovery() rather than the entire struct
> > cfg80211_ap_settings, which wouldn't be a massive change.
> >=20
> >=20
> > I think maybe I even prefer the latter if I'm looking at it now, but I'=
m
> > not sure I'm not missing something from earlier discussions on this.
>=20
> The second option will take couple of weeks due to current work load.=20

Since you didn't seem to be opposed, I just did the second thing myself
now, it wasn't really hard. :)

johannes