Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <e1594171-6859-6b93-e865-3216975e6135@quicinc.com>
Date:   Mon, 25 Sep 2023 17:24:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] ath11k: add trace log support
Content-Language: en-US
To:     Venkateswara Naralasetty <quic_vnaralas@quicinc.com>,
        <ath11k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>,
        Jeff Johnson <quic_jjohnson@quicinc.com>
References: <1636439755-30419-1-git-send-email-quic_vnaralas@quicinc.com>
From:   Wen Gong <quic_wgong@quicinc.com>
In-Reply-To: <1636439755-30419-1-git-send-email-quic_vnaralas@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/9/2021 2:35 PM, Venkateswara Naralasetty wrote:
[...]
> diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
> index 5ae2ef4..80f7760 100644
> --- a/drivers/net/wireless/ath/ath11k/wmi.c
> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
> @@ -249,6 +249,8 @@ static int ath11k_wmi_cmd_send_nowait(struct ath11k_pdev_wmi *wmi, struct sk_buf
>   	cmd_hdr = (struct wmi_cmd_hdr *)skb->data;
>   	cmd_hdr->cmd_id = cmd;
>   
> +	trace_ath11k_wmi_cmd(ab, cmd_id, skb->data, skb->len);
> +
>   	memset(skb_cb, 0, sizeof(*skb_cb));
>   	ret = ath11k_htc_send(&ab->htc, wmi->eid, skb);
>   

This will trace 3 times because ath11k_wmi_cmd_send()

calls ath11k_wmi_cmd_send_nowait() 3 times when the credit is not 
available.

Any one know how to change it with a good way?

[...]

>