Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1578140rdh; Mon, 25 Sep 2023 18:15:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/n5Q5igr8AOqIpQYblnqv91Q/mazRQ2k/TbQevd3WJZmA8bC5IVY56fAcexqaPKRVWDng X-Received: by 2002:a17:90b:3e8c:b0:277:11b1:d5c4 with SMTP id rj12-20020a17090b3e8c00b0027711b1d5c4mr7448350pjb.41.1695690919505; Mon, 25 Sep 2023 18:15:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695690919; cv=none; d=google.com; s=arc-20160816; b=pRmmJxPaJZzeBiQ9o17yqyLrQO6E5DtAk0w0H605ZnDy/GDrdkKRLQFtsZD3WmEzhv SdCA8DFS1zjwFZDKs72gkGL8CDUrjA5tOd0hDMnK9JZQ22vyPp5aO4zO/lsv8c+B4SNz SS1ZaXBNFrmXA7O9ExsrACbRcK+4gNNXQa9q0oT/nMYlMK+RRIXaa0gPILVOSdZb750X /KmpAw43xIA7rjRTiLupm8tOd1QlzX0M+x84hOwWlYxkuW6rHgahFx8HF1h35au70TID aLtKv5VxMMIpJZxS31heUP/pDnbO/iGzTDlRSulLofXS4ZYkM6Fib5CgFSjbR9S5IUkJ 1sLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=ty+T3deiRMTqLzciKWfQDR9XJlZPUJWC2tx/G7/3awk=; fh=2hI485HFlXJy+4lLjgPX5/GYVcxclaS/2eVblZtiuKQ=; b=cojcXGPJy8twTRsnsV/6lw2IXE6dDlfAS0mQjimzCjP53lxcEh5IIumXK4O9hHPyYE oV3QOp60qgLhp5aGaBPgrNpbvh67h4egTMd6fL9E2D3Ehu9pE/E7zFW4sIunFF2Dy4lr /1fVfE9H4nTffy23XJu7HEFeg9pk4aWe9IDLFQZV7n8BH+6OhbgSkrj8LP8Fn8cIFaEe gvsrXiStDujljx2veaSyUXS/p97Ytl1h0qick3whziKch2HiqV9//P3+8UxoA+6AWrsD jmTnkl76gLVon+NVYYkHDM83rUWoUHn5lzNNsaiLBRHNC1LdLxuDzNRb0BbfYHZZLzTa 81UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bk13-20020a17090b080d00b00276f10d241fsi5613517pjb.37.2023.09.25.18.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 18:15:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 631B9802076E; Mon, 25 Sep 2023 18:15:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231767AbjIZBPM convert rfc822-to-8bit (ORCPT + 56 others); Mon, 25 Sep 2023 21:15:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbjIZBPL (ORCPT ); Mon, 25 Sep 2023 21:15:11 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ECC910C for ; Mon, 25 Sep 2023 18:15:05 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 38Q1El4R2182003, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 38Q1El4R2182003 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Sep 2023 09:14:47 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Tue, 26 Sep 2023 09:14:47 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 26 Sep 2023 09:14:47 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::7445:d92b:d0b3:f79c]) by RTEXMBS04.realtek.com.tw ([fe80::7445:d92b:d0b3:f79c%5]) with mapi id 15.01.2375.007; Tue, 26 Sep 2023 09:14:46 +0800 From: Ping-Ke Shih To: Dmitry Antipov CC: Kalle Valo , "linux-wireless@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: RE: [PATCH] wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines Thread-Topic: [PATCH] wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines Thread-Index: AQHZ7491+xF24f17okm2DcK8Rg2xbrAsTkmw Date: Tue, 26 Sep 2023 01:14:46 +0000 Message-ID: <6f07468cf7e94fa3baa7b9277b281921@realtek.com> References: <20230925090452.25633-1-dmantipov@yandex.ru> In-Reply-To: <20230925090452.25633-1-dmantipov@yandex.ru> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.69.25] x-kse-serverinfo: RTEXMBS02.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 18:15:17 -0700 (PDT) > -----Original Message----- > From: Dmitry Antipov > Sent: Monday, September 25, 2023 5:05 PM > To: Ping-Ke Shih > Cc: Kalle Valo ; linux-wireless@vger.kernel.org; lvc-project@linuxtesting.org; Dmitry > Antipov > Subject: [PATCH] wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines > > Since 'u8' comparison against zero is always false, drop the > corresponding branches of AMPDU_MIN_SPACE adjustment within > 'rtlxxxx_set_hw_reg()' for rtl8188ee, rtl8192ce, rtl8192de, > rtl8723ae, rtl8723be, and rtl8821ae. Compile tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov Acked-by: Ping-Ke Shih