Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1726208rdh; Tue, 26 Sep 2023 01:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcWzuxBZLey37La38HlK7WZS9hBjmmzfVZVMmfkT8PPZZGW8L1+81ofdGztCWcY2pzzVbu X-Received: by 2002:a17:902:e74c:b0:1c5:a7b7:291c with SMTP id p12-20020a170902e74c00b001c5a7b7291cmr11533769plf.12.1695716391494; Tue, 26 Sep 2023 01:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695716391; cv=none; d=google.com; s=arc-20160816; b=GLSoZKu8gLJbZ0DAh9QMmW9eVFWo9E1ZIx7W6Y9AwhdeaSjsFKEYa4wLmORe0ku1xB YRY77OCzCL7myB/vUVaYbvhVtiOseVUcZVUpR2dxpPX4sgOhv7D21QPp/toqzPHvrKmj n36tM9+ozJRPS6JS2+17N+2l67gH/iISEoDd5aoa6TXZbaroxPd92RnoFZvp3pnhSc6Q MNRYsqk/lbqc7WUhN/mEAoLoQauhfVxCqRoDEtVHBfv/vGKajvYodYCyD+RSYm8pfOYB f1qg9p0lojfVv5kKJ2QIme2EbRxLW+wziJXb7IxYG0TLyPBc/IeoQwXuEXHVEQiRqQXS B/9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9A6XkN1aL04AC5oo3mMq3DYHp4+APgENKnC8frTiAOw=; fh=Y2IfAqdjkYQAx7XZcGq/8JceY1atOOwfX771vvMvH7o=; b=yBGKmcimKAjbjqcJCnxqB9iEtNF2Ya77b7U5vEoFhd9uz7P6jRNDc1OXudi7SOMsb9 tjhNn3aA/5muWmn5w9+jUiBntXZPhXMVk2O9Cd/s17eNWQfRxxNQzZ7e3F9cmaE/zjLr 5+lAnxwH6JjwdfafY/RjWPgZ2Fj395z08WedYV0JdJLTi9B5pFdUF5AcB7IUYIz+BhHE 81dhhSQBOSm6ljQksMrtkZ7OZDMmzVttIWVBowQ6tYQQrYoXhuGOPzwWzjkoInEZDzht H9VJd7+b/KIlbuM/pcaIbRM0qN3VSFZPloPGOljhQTXh81PjworltheQuOnxGVLk4PLK 1Arw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SzfdYvgX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ik28-20020a170902ab1c00b001b9c3498526si72421plb.433.2023.09.26.01.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 01:19:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SzfdYvgX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 7DE568083B4C; Tue, 26 Sep 2023 01:07:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233835AbjIZIHt (ORCPT + 56 others); Tue, 26 Sep 2023 04:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbjIZIHr (ORCPT ); Tue, 26 Sep 2023 04:07:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 781CAFB for ; Tue, 26 Sep 2023 01:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695715661; x=1727251661; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7KPEIfZnZJIEk8vYHWCS6OmFMBaSkBISCdKs5Fp1eEk=; b=SzfdYvgX6/AMqmbsQ/4H8rlRYMkrWmCvLPfzTYDbcd5AX/E15UoRiFsf VsDlmhonmRrfJEPBW2fHcRv3AX2koREA8HJ+K8O3W3DKeAoTJWcM2MD5J UBKYVEbgeqdfFwtY9TB2pi5A+QjauRVdi5UnVADNL6sjEiaBiIHpkanO2 SuB+RwQGCPKjLw6y4tFXXSMSlDIsj5FtkgMU22LuRDzKdFDZYiFrY7xaP dvuk9DCBAdPBj7k18m1AFrrHKh0wZoByO+W/XLfDvUkrPXzYg/vAf1PxF cNLDK3+KxDMwmmbOC5FAecDtuwxxq/2fAhCsg5GM0FolK55Lg2KFfE+LX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="467797245" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="467797245" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="698369274" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="698369274" Received: from nbenitzh-mobl2.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.251.178.250]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:39 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 3/9] wifi: iwlwifi: skip opmode start retries on dead transport Date: Tue, 26 Sep 2023 11:07:15 +0300 Message-Id: <20230926110319.9f472069d75d.Ib6684c5b2ea8ed98f082c9b0e9bb2b03c3ea4fe3@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230926080721.876640-1-gregory.greenman@intel.com> References: <20230926080721.876640-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 01:07:57 -0700 (PDT) From: Johannes Berg These retries aren't going to succeed if the device was deemed dead and needs to be unbound/rebound/... to be recovered; skip the retries in that case. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index fb5e254757e7..41ae4fae4b8a 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -1429,6 +1429,9 @@ _iwl_op_mode_start(struct iwl_drv *drv, struct iwlwifi_opmode_table *op) if (op_mode) return op_mode; + if (test_bit(STATUS_TRANS_DEAD, &drv->trans->status)) + break; + IWL_ERR(drv, "retry init count %d\n", retry); #ifdef CONFIG_IWLWIFI_DEBUGFS -- 2.38.1