Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1726214rdh; Tue, 26 Sep 2023 01:19:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzwvrHhhmS6yTmx0CvlJJZKzihh9SkFW0lGa1lBu/f5nnLV5knKf1/5JH4EOSuIKsYTYKU X-Received: by 2002:a17:903:120b:b0:1bf:650b:14fb with SMTP id l11-20020a170903120b00b001bf650b14fbmr7197114plh.42.1695716392563; Tue, 26 Sep 2023 01:19:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695716392; cv=none; d=google.com; s=arc-20160816; b=ustQzrMg5q/Z9wYKMNFytByDprJ3+hSV7A/BcO07zNCqjSOXw3Hk1DnXKjmnHF1UON 8XugAUnRSCfQmQuNHdrXUYZ6bUv9WxaUzPB9OLrqu1J6HXt+NNWbAgXCpz6HhvolEmAQ hVk6Ac87mVLE4eiDqHJgMlsIXTSBBA0l3mp1kvj5qmBN1eXq5iA9j9tYdB1FyE4NDuNd BQxw1wGnt0TJ5lFR8Hz1smbde/Xp6AG3h22HMuvahKr36Ne6hW9Hqk4jRI1/zxyucxU4 piRFCfsQkmdPsFJzLrPksLlMsIogEdWsrXKXV16txvSnUaK32wi+yfNagQ/MN3iYe8U8 4Z4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yIQOo9iLWxWm6SfidpKwyIWP2Gkh0rQCbGwymokWS7E=; fh=NrzcX6n/fIKQZEVAowFne6P9rOqJ7jYMirs59KlRnMw=; b=qTBq3LVeciw5WEWPW3mAk378Ie0Dhskxcv4qJzw4IgzcCnswddZ7CyFJFd9Ipi56bD 7lwDjhjfBsnZ0ucy8TFfniRsvv2BJMYdrmUaiw7TyCA0x358nNx/G7DwyAKoalPPzzU0 5Bje5AfkW1nXQBN0GmE0d5Us+lrhnZX6Q2jCmd9CLgMwMW/odbfhVj5tBqj6xysrswMs dMNJkJh5cxtzMsAlE9qt52/PiZRcsL4K+ThYoDSIDDZ1D/cV4vjDumxUtIeuUkxMdJOv yVCRFXj8pTmC8NQ5ItaWlZsnvKcd26JiBme/ALIkk9N4RM/Vgz7eU5bdHwAtzmH/E8ch rQKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZuSlBcaC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u10-20020a170902714a00b001bb8a57d518si11481544plm.379.2023.09.26.01.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 01:19:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZuSlBcaC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C2FFE80743C7; Tue, 26 Sep 2023 01:07:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233837AbjIZIH5 (ORCPT + 56 others); Tue, 26 Sep 2023 04:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233840AbjIZIHz (ORCPT ); Tue, 26 Sep 2023 04:07:55 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E537010A for ; Tue, 26 Sep 2023 01:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695715668; x=1727251668; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MfZQ5Srpmrnx7HdS0D9tyy7H/6LupCQ5lmuwdBqc/0w=; b=ZuSlBcaCQ1bupzUl7U3jM8yAFPxK6+qDA8itz/v97UsSI4bJo9utCHuG dN/0Yn5ihayoq6ACbTm0FxF0KzkgK9Y+S6l1IrezGaRwcx0wosDQRspPA CnE391nOKVVqqG4zisR45RYKlIfZxzA2UtM2FHL3lHiBnpp2gv0dqaoy6 KHLxTyCgx4PaL3DapwprcSvWwsq9xYGdEdEy0Srz7x0jMOsfy0USpdkSx HXIpB4AAZBDA/4C4MR6Pq2v97in689iZd72+TOALOVaCu3FOi5uKAYMkL nEDj6z/WMg44u5pZwqXcJn8PgzMk+CZYF5Gn6t/NknI3nACbt7Qh7JgtJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="467797269" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="467797269" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="698369291" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="698369291" Received: from nbenitzh-mobl2.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.251.178.250]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:47 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Avraham Stern , Gregory Greenman Subject: [PATCH 6/9] wifi: iwlwifi: mvm: fix removing pasn station for responder Date: Tue, 26 Sep 2023 11:07:18 +0300 Message-Id: <20230926110319.7eb353abb95c.I2b30be09b99f5a2379956e010bafaa465ff053ba@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230926080721.876640-1-gregory.greenman@intel.com> References: <20230926080721.876640-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 01:07:58 -0700 (PDT) From: Avraham Stern In case of MLD operation the station should be removed using the mld api. Fixes: fd940de72d49 ("wifi: iwlwifi: mvm: FTM responder MLO support") Signed-off-by: Avraham Stern Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c index b49781d1a07a..10b9219b3bfd 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause /* * Copyright (C) 2015-2017 Intel Deutschland GmbH - * Copyright (C) 2018-2022 Intel Corporation + * Copyright (C) 2018-2023 Intel Corporation */ #include #include @@ -302,7 +302,12 @@ static void iwl_mvm_resp_del_pasn_sta(struct iwl_mvm *mvm, struct iwl_mvm_pasn_sta *sta) { list_del(&sta->list); - iwl_mvm_rm_sta_id(mvm, vif, sta->int_sta.sta_id); + + if (iwl_mvm_has_mld_api(mvm->fw)) + iwl_mvm_mld_rm_sta_id(mvm, sta->int_sta.sta_id); + else + iwl_mvm_rm_sta_id(mvm, vif, sta->int_sta.sta_id); + iwl_mvm_dealloc_int_sta(mvm, &sta->int_sta); kfree(sta); } -- 2.38.1