Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1800374rdh; Tue, 26 Sep 2023 04:09:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHO1DLrdS8jQkV9Cq48Z+VfHHkKTd9boDHAAb6brmkGf0oMl3ztRqIPadvi3uAQg6cm+GuM X-Received: by 2002:a05:6a00:139b:b0:690:28d0:b7cf with SMTP id t27-20020a056a00139b00b0069028d0b7cfmr9249031pfg.16.1695726550279; Tue, 26 Sep 2023 04:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695726550; cv=none; d=google.com; s=arc-20160816; b=cDdFw7fqKPtZj4BOSHGpmOey8jeOM3A705cVoiMkH3vDDHQQPZFUBm+kZg9giTOw08 T2UASq2bkUd0mlWS1pAD4lUJaDoLqBtj4J3iWUXrI2LISjgfLCKzyC4sTLVCXazWmoUa 4VXk2gyCb0ZzZsSejGokFQKhMXjVaMvgiUVjIpt6rSDydCpk711BP4KI2v5JEceGGtNQ GF+1dC6weIXeBpH2zcQyMqldTJfPvNqVj4HyvBwFumhdxmU3niegO7DC2L4g3hjVlHEb hrlmWYvrbp7Z7d3rIx3D5H2UfEsg0M4c7r6dHYDNbCwTZaa6o+aLATzsm91fE8tfZwa2 T1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nlvFDzG+Sy4qnBKqSIWXF+BUAHm91db/XCimKmhBp8k=; fh=NrzcX6n/fIKQZEVAowFne6P9rOqJ7jYMirs59KlRnMw=; b=yojdxYX60LZqB8IQZrs6QiyEdgLoIzlwLUZoBDqhqac7MQuy4pLh4WtgsjCJYBzX+C WbssN5DMryj1/Gbh3OogaZeAdqGm0WfG9UquCvw1wDpim3NYMkDfxx0jaWZ8azhgcSuU sh5BobDSKVx+Cf9FQXqsJ/wXitwsTJqjqc6p237CdGb8uGf/yj6dxfOnjEKl8iVPTAr7 mcsPnlyMaZduHiUOrTHXEOoVr9u0njXXPoupM0Ixf2vnw+SLVAloMWW9zrpgk2/EYvEd ywFM2D5y7zAwdECPmSGJG6FPrXq/bBGgYM+xNvL50G0kNujhwwcgKWwdbjlX7yYbPbUb m6uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GN3aFqnY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id cr15-20020a056a000f0f00b0068fe8cac913si12194694pfb.324.2023.09.26.04.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 04:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GN3aFqnY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1DBCA8083E59; Tue, 26 Sep 2023 01:07:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbjIZIHo (ORCPT + 56 others); Tue, 26 Sep 2023 04:07:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbjIZIHm (ORCPT ); Tue, 26 Sep 2023 04:07:42 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4A7FC for ; Tue, 26 Sep 2023 01:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695715656; x=1727251656; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=shP0liIzuLg4auyW1ffFDnjNNe9mZbNVfTHCZnudP5I=; b=GN3aFqnYQz2Hpu1XVL9uKeesvTuRsxxOEIWk+tk7JBeae3qQ4HXyR0CV ZN0VkKCTZ4/zUkOK2nNoVV+ESPzRjBBZNF1HSzwN28leU3tRKNBEq9EpB z5a+vw/PGUzWH+/fT6EnxWDuKopPkWK+Tqu1iFF2ifLzRP4H+ZsmZaaik XWoT1G5aACpJCYAesZIQVMiazaktfn1UUg6gWrdosx8Cd3i1eMJk29WQm WCi7iuiviQ/XDm809KvMV6a3ZJPDLP1Ve8nvfsfkuQTkehXUZdYgepOjb xpPTBX2ShNv9/iLg+lirDg9bfZZ/5PDg7Nwy9sJ3I1OKE5MQazrlyn9Ze A==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="467797229" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="467797229" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="698369257" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="698369257" Received: from nbenitzh-mobl2.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.251.178.250]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 01:07:34 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Avraham Stern , Gregory Greenman Subject: [PATCH 1/9] wifi: iwlwifi: mvm: update station's MFP flag after association Date: Tue, 26 Sep 2023 11:07:13 +0300 Message-Id: <20230926110319.2488cbd01bde.Ic0f08b7d3efcbdce27ec897f84d740fec8d169ef@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230926080721.876640-1-gregory.greenman@intel.com> References: <20230926080721.876640-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 01:07:40 -0700 (PDT) From: Avraham Stern The management frames protection flag is always set when the station is not yet authorized. However, it was not cleared after association even if the association did not use MFP. As a result, all public action frames are not parsed by fw (which will cause FTM to fail, for example). Update the station MFP flag after the station is authorized. Fixes: 4c8d5c8d079e ("wifi: iwlwifi: mvm: tell firmware about per-STA MFP enablement") Signed-off-by: Avraham Stern Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 6fc5b3f22746..f9a4168e3e1a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -3809,6 +3809,12 @@ iwl_mvm_sta_state_assoc_to_authorized(struct iwl_mvm *mvm, iwl_mvm_rs_rate_init_all_links(mvm, vif, sta); + /* MFP is set by default before the station is authorized. + * Clear it here in case it's not used. + */ + if (!sta->mfp) + return callbacks->update_sta(mvm, vif, sta); + return 0; } -- 2.38.1